Issue 35100043: Rename my_asn1 to asn1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35100043: Rename my_asn1 to asn1

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by ekasper

Modified:
10 years, 5 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Rename my_asn1 to asn1

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -3195 lines)			Patch
M	src/python/Makefile	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/oid.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/oid_test.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/tag.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/tag_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	src/python/ct/crypto/asn1/type_test_base.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/types.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	src/python/ct/crypto/asn1/types_test.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/x509.py	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/x509_extension.py	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/x509_name.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/x509_time.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	src/python/ct/crypto/asn1/x509_time_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/python/ct/crypto/cert.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/oid.py	View	1 chunk	+0 lines, -304 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/oid_test.py	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/tag.py	View	1 chunk	+0 lines, -107 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/tag_test.py	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/type_test_base.py	View	1 chunk	+0 lines, -96 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/types.py	View	1 chunk	+0 lines, -1378 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/types_test.py	View	1 chunk	+0 lines, -668 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/x509.py	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/x509_extension.py	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/x509_name.py	View	1 chunk	+0 lines, -150 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/x509_time.py	View	1 chunk	+0 lines, -152 lines	0 comments	Download
D	src/python/ct/crypto/my_asn1/x509_time_test.py	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	src/python/ct/crypto/name.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ekasper

And the renaming part of https://codereview.appspot.com/34770043/

10 years, 5 months ago (2013-11-29 11:18:05 UTC) #1

LGTM

Expand All Messages | Collapse All Messages