Remove old ASN.1 code

Remove old ASN.1 code

[ekasper, 2013-11-28 13:57:51]

Nothing to see here, really, just getting rid of old, unused code.

Note that x509_name_test.py and x509_extension_test.py have gone away as the
decoding of those is now automatically handled and tested at the base types
level.

[Eran, 2013-11-28 16:47:40]

I'm a bit confused: Are the files in ct/crypto/asn1/ being moved to
ct/crypto/my_asn1 ?
For example, oid.py in ct/crypto/my_asn1 already has the contents shown in this
patchset as a diff from ct/crypto/asn1/oid.py. 
I'd be surprised if you expect the content to be duplicated.

https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile
File src/python/Makefile (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile#newcode14
src/python/Makefile:14: PYTHONPATH=$(PYTHONPATH):. ./ct/crypto/asn1/tag_test.py
We might as well create a test suite for all of our unit tests.
It should be as simple as:
class CTAllTests:
  def __init__(self):
    self._all_tests = unittest.TestSuite()

    # Add all tests
    self._all_tests.addTest(unittest.TestLoader().discover('.'))

  def run_tests(self):
    unittest.TextTestRunner().run(self._all_tests);

https://codereview.appspot.com/34770043/diff/20001/src/python/README
File src/python/README (left):

https://codereview.appspot.com/34770043/diff/20001/src/python/README#oldcode10
src/python/README:10: pyasn1 (0.1.7)
Nice to see it gone!

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/oid.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/oid.py:18: return _OID_NAME_DICT[self][dict_idx]
Nit: since it's an expected flow (some OIDs will not have names) I suggest:
if self in _OID_NAME_DICT:
  return _OID_NAME_DICT[self][dict_idx]
else:
  return ".".join...

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/tag.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/tag.py:1: """ASN.1 tagging."""
This file does not seem to have any changes?

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/type_test_base.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/type_test_base.py:1: import unittest
Again, this file does not seem to have any changes?

[ekasper, 2013-11-28 17:45:15]

On 2013/11/28 16:47:40, Eran wrote:
> I'm a bit confused: Are the files in ct/crypto/asn1/ being moved to
> ct/crypto/my_asn1 ?
> For example, oid.py in ct/crypto/my_asn1 already has the contents shown in
this
> patchset as a diff from ct/crypto/asn1/oid.py. 
> I'd be surprised if you expect the content to be duplicated.

my_asn1/ is being moved to asn1/ which shows up a little funny because some
files with the same name already existed. In particular moving ('git mv -f') to
an existing destination shows up as a diff.

If it's utterly confusing then I can do a delete followed by a move in two CLs?

> https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile
> File src/python/Makefile (right):
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile#newcode14
> src/python/Makefile:14: PYTHONPATH=$(PYTHONPATH):.
./ct/crypto/asn1/tag_test.py
> We might as well create a test suite for all of our unit tests.
> It should be as simple as:
> class CTAllTests:
>   def __init__(self):
>     self._all_tests = unittest.TestSuite()
> 
>     # Add all tests
>     self._all_tests.addTest(unittest.TestLoader().discover('.'))
> 
>   def run_tests(self):
>     unittest.TextTestRunner().run(self._all_tests);
> 
> https://codereview.appspot.com/34770043/diff/20001/src/python/README
> File src/python/README (left):
> 
> https://codereview.appspot.com/34770043/diff/20001/src/python/README#oldcode10
> src/python/README:10: pyasn1 (0.1.7)
> Nice to see it gone!
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> File src/python/ct/crypto/asn1/oid.py (right):
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> src/python/ct/crypto/asn1/oid.py:18: return _OID_NAME_DICT[self][dict_idx]
> Nit: since it's an expected flow (some OIDs will not have names) I suggest:
> if self in _OID_NAME_DICT:
>   return _OID_NAME_DICT[self][dict_idx]
> else:
>   return ".".join...
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> File src/python/ct/crypto/asn1/tag.py (right):
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> src/python/ct/crypto/asn1/tag.py:1: """ASN.1 tagging."""
> This file does not seem to have any changes?
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> File src/python/ct/crypto/asn1/type_test_base.py (right):
> 
>
https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
> src/python/ct/crypto/asn1/type_test_base.py:1: import unittest
> Again, this file does not seem to have any changes?

[ekasper, 2013-11-28 17:46:46]

https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile
File src/python/Makefile (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/Makefile#newcode14
src/python/Makefile:14: PYTHONPATH=$(PYTHONPATH):. ./ct/crypto/asn1/tag_test.py
On 2013/11/28 16:47:40, Eran wrote:
> We might as well create a test suite for all of our unit tests.
> It should be as simple as:
> class CTAllTests:
>   def __init__(self):
>     self._all_tests = unittest.TestSuite()
> 
>     # Add all tests
>     self._all_tests.addTest(unittest.TestLoader().discover('.'))
> 
>   def run_tests(self):
>     unittest.TextTestRunner().run(self._all_tests);

Happy to, I've added a TODO.

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/oid.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/oid.py:18: return _OID_NAME_DICT[self][dict_idx]
On 2013/11/28 16:47:40, Eran wrote:
> Nit: since it's an expected flow (some OIDs will not have names) I suggest:
> if self in _OID_NAME_DICT:
>   return _OID_NAME_DICT[self][dict_idx]
> else:
>   return ".".join...

Note this is actually a move from another directory, which shows up as a diff
because a file with the same name existed.

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/tag.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/tag.py:1: """ASN.1 tagging."""
On 2013/11/28 16:47:40, Eran wrote:
> This file does not seem to have any changes?

It's a move from another directory.

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/type_test_base.py (right):

https://codereview.appspot.com/34770043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/type_test_base.py:1: import unittest
On 2013/11/28 16:47:40, Eran wrote:
> Again, this file does not seem to have any changes?

Ditto.

[Eran, 2013-11-28 20:45:00]

Please do send out two separate patches for review - you could still commit them
as one change moving files around. It's rather confusing otherwise.