A reply to you comments has been entered. to support testing, I have set all ...
5 years, 8 months ago
(2018-01-04 01:52:21 UTC)
#4
A reply to you comments has been entered.
to support testing, I have set all test and examples for all modules to no
logging. there are in excess of 550 tests and examples that get run by test.py
when testing NS-3.
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-...
File src/uan/examples/uan-cw-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-...
src/uan/examples/uan-cw-example.cc:270: LogComponentEnable ("UanCwExample",
LOG_LEVEL_ALL);
On 2018/01/03 14:10:07, Fedwar wrote:
> why is this commented out?
> thanks
to support testing, I have set all test and examples for all modules to no
logging. there are in excess of 550 tests and examples that get run by test.py
when testing NS-3.
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-...
File src/uan/examples/uan-rc-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-...
src/uan/examples/uan-rc-example.cc:255: LogComponentEnable ("UanRcExample",
LOG_LEVEL_ALL);
On 2018/01/03 14:10:07, Fedwar wrote:
> why is this commented out?
> thanks
to support testing, I have set all test and examples for all modules to no
logging. there are in excess of 550 tests and examples that get run by test.py
when testing NS-3.
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc File src/uan/examples/uan-cw-example.cc (right): https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269 src/uan/examples/uan-cw-example.cc:269: #if 0 Tom, I need feedback from you. Is ...
5 years, 8 months ago
(2018-01-15 07:54:12 UTC)
#5
I very love my wife https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc File src/uan/examples/uan-cw-example.cc (right): https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269 src/uan/examples/uan-cw-example.cc:269: #if 0 I love ...
5 years, 8 months ago
(2018-01-21 16:41:25 UTC)
#6
On 2018/02/11 19:45:33, ammo6818-vandals.uidaho.edu wrote: > Review comments have been addressed and patch ready to ...
5 years, 7 months ago
(2018-02-16 09:11:44 UTC)
#12
On 2018/02/11 19:45:33, ammo6818-vandals.uidaho.edu wrote:
> Review comments have been addressed and patch ready to upload to ns-3-dev
Hello,
I'm reporting here the comments from Tom Henderson, which did not go through (he
sent them via mail).
This is about the modifications to uan-cw-example.cc and uan-rc-example.cc
(i.e. the #if 0)
----
Sorry for the delay in replying (I just read this for the first time now).
I think that the solution here is to do this:
bool quiet = false;
CommandLine cmd;
cmd.AddValue (quiet, "Run in quiet mode (disable logging)", quiet);
....
if (!quiet)
{
LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
}
This way, you can keep the default behavior (if you prefer) of logging
being on, but if Robert wants to run it in a testing context, he can
pass the --quiet flag.
On 2018/02/16 09:11:44, Fedwar wrote: > On 2018/02/11 19:45:33, http://ammo6818-vandals.uidaho.edu wrote: > > Review comments ...
5 years, 7 months ago
(2018-02-18 00:22:52 UTC)
#13
On 2018/02/16 09:11:44, Fedwar wrote:
> On 2018/02/11 19:45:33, http://ammo6818-vandals.uidaho.edu wrote:
> > Review comments have been addressed and patch ready to upload to ns-3-dev
>
> Hello,
> I'm reporting here the comments from Tom Henderson, which did not go through
(he
> sent them via mail).
> This is about the modifications to uan-cw-example.cc and uan-rc-example.cc
>
> (i.e. the #if 0)
>
> ----
>
>
> Sorry for the delay in replying (I just read this for the first time now).
>
>
>
> I think that the solution here is to do this:
>
>
>
> bool quiet = false;
>
>
>
> CommandLine cmd;
>
> cmd.AddValue (quiet, "Run in quiet mode (disable logging)", quiet);
>
> ....
>
>
>
> if (!quiet)
>
> {
>
> LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
>
> }
>
>
>
> This way, you can keep the default behavior (if you prefer) of logging
> being on, but if Robert wants to run it in a testing context, he can
> pass the --quiet flag.
change incorporated
Issue 338000043: Eliminate Visual Studio complier warnings
(Closed)
Created 5 years, 10 months ago by ammo6818-vandals.uidaho.edu
Modified 5 years, 6 months ago
Reviewers: Fedwar
Base URL:
Comments: 22
