Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2533)

Issue 338000043: Eliminate Visual Studio complier warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ammo6818-vandals.uidaho.edu
Modified:
21 hours, 15 minutes ago
Reviewers:
Fedwar
CC:
ns-3-reviews_googlegroups.c, ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio complier warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Total comments: 15

Patch Set 3 : Updated patch to address review comments #

Patch Set 4 : Updated patch to address review comments #

Patch Set 5 : Update patch for latest review comments #

Patch Set 6 : Changes to patch set to eliminate some casts #

Total comments: 4

Patch Set 7 : Patch updates for x64 build #

Total comments: 3

Patch Set 8 : Upadates to patch set for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M src/uan/examples/uan-cw-example.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -2 lines 0 comments Download
M src/uan/examples/uan-rc-example.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -3 lines 0 comments Download
M src/uan/helper/uan-helper.cc View 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/uan/model/uan-address.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/uan/model/uan-channel.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/uan/model/uan-header-rc.cc View 1 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/uan/model/uan-mac-aloha.cc View 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/uan/model/uan-mac-cw.cc View 4 5 2 chunks +2 lines, -1 line 0 comments Download
M src/uan/model/uan-mac-rc.cc View 1 2 3 4 5 6 6 chunks +7 lines, -6 lines 0 comments Download
M src/uan/model/uan-mac-rc-gw.cc View 1 2 3 4 5 6 10 chunks +12 lines, -8 lines 0 comments Download
M src/uan/model/uan-net-device.cc View 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M src/uan/model/uan-phy-dual.h View 1 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/uan/model/uan-phy-dual.cc View 4 5 2 chunks +2 lines, -1 line 0 comments Download
M src/uan/model/uan-phy-gen.cc View 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/uan/model/uan-prop-model.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/uan/model/uan-tx-mode.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/uan/test/uan-energy-model-test.cc View 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/uan/test/uan-test.cc View 1 2 4 5 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 13
Fedwar
2nd draft review complete https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h File src/uan/model/uan-mac-aloha.h (left): https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30 src/uan/model/uan-mac-aloha.h:30: can we revert this .h ...
2 months ago (2017-12-19 14:07:38 UTC) #1
ammo6818-vandals.uidaho.edu
Patch has been updated to address your review comments. Please let me know if you ...
1 month, 3 weeks ago (2017-12-23 06:03:49 UTC) #2
Fedwar
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc File src/uan/examples/uan-cw-example.cc (right): https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc#newcode270 src/uan/examples/uan-cw-example.cc:270: LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL); why is this commented out? thanks ...
1 month, 2 weeks ago (2018-01-03 14:10:07 UTC) #3
ammo6818-vandals.uidaho.edu
A reply to you comments has been entered. to support testing, I have set all ...
1 month, 2 weeks ago (2018-01-04 01:52:21 UTC) #4
Fedwar
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc File src/uan/examples/uan-cw-example.cc (right): https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269 src/uan/examples/uan-cw-example.cc:269: #if 0 Tom, I need feedback from you. Is ...
1 month ago (2018-01-15 07:54:12 UTC) #5
baby546833
I very love my wife https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc File src/uan/examples/uan-cw-example.cc (right): https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269 src/uan/examples/uan-cw-example.cc:269: #if 0 I love ...
4 weeks ago (2018-01-21 16:41:25 UTC) #6
baby546833
love my wife
4 weeks ago (2018-01-21 16:42:32 UTC) #7
baby546833
I love my wife https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h File src/uan/model/uan-mac-aloha.h (left): https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30 src/uan/model/uan-mac-aloha.h:30: 賤女人 https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30 src/uan/model/uan-mac-aloha.h:30: 賤女人死妓女 https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30 ...
3 weeks, 4 days ago (2018-01-24 09:23:58 UTC) #8
baby546833
3 weeks, 2 days ago (2018-01-26 08:53:09 UTC) #9
baby546833
fuck
3 weeks, 2 days ago (2018-01-26 08:54:25 UTC) #10
ammo6818-vandals.uidaho.edu
Review comments have been addressed and patch ready to upload to ns-3-dev
1 week ago (2018-02-11 19:45:33 UTC) #11
Fedwar
On 2018/02/11 19:45:33, ammo6818-vandals.uidaho.edu wrote: > Review comments have been addressed and patch ready to ...
2 days, 13 hours ago (2018-02-16 09:11:44 UTC) #12
ammo6818-vandals.uidaho.edu
21 hours, 52 minutes ago (2018-02-18 00:22:52 UTC) #13
On 2018/02/16 09:11:44, Fedwar wrote:
> On 2018/02/11 19:45:33, http://ammo6818-vandals.uidaho.edu wrote:
> > Review comments have been addressed and patch ready to upload to ns-3-dev
> 
> Hello,
> I'm reporting here the comments from Tom Henderson, which did not go through
(he
> sent them via mail).
> This is about the modifications to uan-cw-example.cc and uan-rc-example.cc 
> 
> (i.e. the #if 0)
> 
> ----
> 
> 
> Sorry for the delay in replying (I just read this for the first time now).
> 
> 
> 
> I think that the solution here is to do this:
> 
> 
> 
> bool quiet = false;
> 
> 
> 
> CommandLine cmd;
> 
> cmd.AddValue (quiet, "Run in quiet mode (disable logging)", quiet);
> 
> ....
> 
> 
> 
> if (!quiet)
> 
>   {
> 
>     LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
> 
>   }
> 
> 
> 
> This way, you can keep the default behavior (if you prefer) of logging 
> being on, but if Robert wants to run it in a testing context, he can 
> pass the --quiet flag.

change incorporated
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d