Code review - Issue 338000043: Eliminate Visual Studio complier warningshttps://codereview.appspot.com/2018-02-18T01:00:43+00:00rietveld
Message from unknown
2017-11-10T21:50:16+00:00ammo6818-vandals.uidaho.eduurn:md5:572eb8bb9ed90817c0c5350a3b8a5d74
Message from unknown
2017-12-09T01:54:40+00:00ammo6818-vandals.uidaho.eduurn:md5:5e83b866cb9d6cdea05008e2b15cd7ae
Message from fedwar@gmail.com
2017-12-19T14:07:38+00:00Fedwarurn:md5:fff20fbdb37f59b43d3c0157bca19986
2nd draft review complete
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h
File src/uan/model/uan-mac-aloha.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30
src/uan/model/uan-mac-aloha.h:30:
can we revert this .h file?
there seems to be no real changes
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc-gw.cc
File src/uan/model/uan-mac-rc-gw.cc (right):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc-gw.cc#newcode489
src/uan/model/uan-mac-rc-gw.cc:489: for (uint32_t i = 0; i < data.expFrames; i++)
expFrames is defined as uint8_t,
therefore I would rather change the for definition to
for (uint8_t i = 0; i < data.expFrames; i++)
and remove the cast
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc.h
File src/uan/model/uan-mac-rc.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc.h#oldcode47
src/uan/model/uan-mac-rc.h:47:
no real changes.
revert?
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac.h
File src/uan/model/uan-mac.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac.h#oldcode42
src/uan/model/uan-mac.h:42:
can we revert this .h file?
there are no real changes here, right?
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-transducer.h
File src/uan/model/uan-transducer.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-transducer.h#oldcode36
src/uan/model/uan-transducer.h:36:
revert file? no real changes.
https://codereview.appspot.com/338000043/diff/20001/src/uan/test/uan-test.cc
File src/uan/test/uan-test.cc (right):
https://codereview.appspot.com/338000043/diff/20001/src/uan/test/uan-test.cc#newcode109
src/uan/test/uan-test.cc:109: UanTest::SendOnePacket (Ptr<UanNetDevice> dev, uint32_t mode)
It think it's best if we change the function signature instead to uint16_t mode.
Message from unknown
2017-12-23T06:01:58+00:00ammo6818-vandals.uidaho.eduurn:md5:f84e8b4fb014bc3ff081808256921634
Message from womenrgr8id@gmail.com
2017-12-23T06:03:49+00:00ammo6818-vandals.uidaho.eduurn:md5:52c81d959709c298e7a13c925d762a5f
Patch has been updated to address your review comments.
Please let me know if you have any other review comments. If not, please merge into ns-3-dev repository at your earliest convenience.
Thanks.
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h
File src/uan/model/uan-mac-aloha.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30
src/uan/model/uan-mac-aloha.h:30:
On 2017/12/19 14:07:38, Fedwar wrote:
> can we revert this .h file?
> there seems to be no real change
change to remove blank line reverted
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc-gw.cc
File src/uan/model/uan-mac-rc-gw.cc (right):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc-gw.cc#newcode489
src/uan/model/uan-mac-rc-gw.cc:489: for (uint32_t i = 0; i < data.expFrames; i++)
On 2017/12/19 14:07:38, Fedwar wrote:
> expFrames is defined as uint8_t,
>
> therefore I would rather change the for definition to
>
> for (uint8_t i = 0; i < data.expFrames; i++)
>
> and remove the cast
changed as noted.
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc.h
File src/uan/model/uan-mac-rc.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-rc.h#oldcode47
src/uan/model/uan-mac-rc.h:47:
On 2017/12/19 14:07:38, Fedwar wrote:
> no real changes.
> revert?
change reverted
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac.h
File src/uan/model/uan-mac.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac.h#oldcode42
src/uan/model/uan-mac.h:42:
On 2017/12/19 14:07:38, Fedwar wrote:
> can we revert this .h file?
> there are no real changes here, right?
change reverted
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-transducer.h
File src/uan/model/uan-transducer.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-transducer.h#oldcode36
src/uan/model/uan-transducer.h:36:
On 2017/12/19 14:07:38, Fedwar wrote:
> revert file? no real changes.
change reverted
https://codereview.appspot.com/338000043/diff/20001/src/uan/test/uan-test.cc
File src/uan/test/uan-test.cc (right):
https://codereview.appspot.com/338000043/diff/20001/src/uan/test/uan-test.cc#newcode109
src/uan/test/uan-test.cc:109: UanTest::SendOnePacket (Ptr<UanNetDevice> dev, uint32_t mode)
On 2017/12/19 14:07:38, Fedwar wrote:
> It think it's best if we change the function signature instead to uint16_t mode.
changed as noted.
Message from unknown
2017-12-23T13:23:32+00:00ammo6818-vandals.uidaho.eduurn:md5:69c74cb04ec7c170053c1f2ade65b54a
Message from unknown
2017-12-23T15:13:37+00:00ammo6818-vandals.uidaho.eduurn:md5:93d10cf4316be6807b939b2d1ff4024a
Message from unknown
2017-12-31T17:06:28+00:00ammo6818-vandals.uidaho.eduurn:md5:dc99119f0a305d214a508398ca03b7f3
Message from fedwar@gmail.com
2018-01-03T14:10:07+00:00Fedwarurn:md5:060b23522feb73df811e80d97d0e5901
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc
File src/uan/examples/uan-cw-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc#newcode270
src/uan/examples/uan-cw-example.cc:270: LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
why is this commented out?
thanks
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-example.cc
File src/uan/examples/uan-rc-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-example.cc#newcode255
src/uan/examples/uan-rc-example.cc:255: LogComponentEnable ("UanRcExample", LOG_LEVEL_ALL);
why is this commented out?
thanks
Message from womenrgr8id@gmail.com
2018-01-04T01:52:21+00:00ammo6818-vandals.uidaho.eduurn:md5:29f7532938c9f2a106dac4c3628ea39e
A reply to you comments has been entered.
to support testing, I have set all test and examples for all modules to no logging. there are in excess of 550 tests and examples that get run by test.py when testing NS-3.
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc
File src/uan/examples/uan-cw-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-cw-example.cc#newcode270
src/uan/examples/uan-cw-example.cc:270: LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
On 2018/01/03 14:10:07, Fedwar wrote:
> why is this commented out?
> thanks
to support testing, I have set all test and examples for all modules to no logging. there are in excess of 550 tests and examples that get run by test.py when testing NS-3.
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-example.cc
File src/uan/examples/uan-rc-example.cc (right):
https://codereview.appspot.com/338000043/diff/100001/src/uan/examples/uan-rc-example.cc#newcode255
src/uan/examples/uan-rc-example.cc:255: LogComponentEnable ("UanRcExample", LOG_LEVEL_ALL);
On 2018/01/03 14:10:07, Fedwar wrote:
> why is this commented out?
> thanks
to support testing, I have set all test and examples for all modules to no logging. there are in excess of 550 tests and examples that get run by test.py when testing NS-3.
Message from unknown
2018-01-15T02:28:48+00:00ammo6818-vandals.uidaho.eduurn:md5:9fba19d28e8b2250e27d93164a9c0f50
Message from fedwar@gmail.com
2018-01-15T07:54:12+00:00Fedwarurn:md5:a04203aaa60e1dd2aa7cfc2e685f1fbd
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc
File src/uan/examples/uan-cw-example.cc (right):
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269
src/uan/examples/uan-cw-example.cc:269: #if 0
Tom, I need feedback from you.
Is this OK with you, or do you have another solution in mind?
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-rc-example.cc
File src/uan/examples/uan-rc-example.cc (right):
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-rc-example.cc#newcode254
src/uan/examples/uan-rc-example.cc:254: #if 0
Tom, again, feedback needed :)
thanks
Message from baby546833@gmail.com
2018-01-21T16:41:25+00:00baby546833urn:md5:89a2377c757c21ab8da4cc8cd0efa8fc
I very love my wife
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc
File src/uan/examples/uan-cw-example.cc (right):
https://codereview.appspot.com/338000043/diff/120001/src/uan/examples/uan-cw-example.cc#newcode269
src/uan/examples/uan-cw-example.cc:269: #if 0
I love my wife
Message from baby546833@gmail.com
2018-01-21T16:42:32+00:00baby546833urn:md5:9a866c8d5cdd1c29719df44bf42e79c8
love my wife
Message from baby546833@gmail.com
2018-01-24T09:23:58+00:00baby546833urn:md5:941a187d3a256d07307774370ea60d6e
I love my wife
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h
File src/uan/model/uan-mac-aloha.h (left):
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30
src/uan/model/uan-mac-aloha.h:30:
賤女人
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30
src/uan/model/uan-mac-aloha.h:30:
賤女人死妓女
https://codereview.appspot.com/338000043/diff/20001/src/uan/model/uan-mac-aloha.h#oldcode30
src/uan/model/uan-mac-aloha.h:30:
I love my wife...
Message from baby546833@gmail.com
2018-01-26T08:53:09+00:00baby546833urn:md5:8a4cf9cd80362d7495dffa603f17687b
Message from baby546833@gmail.com
2018-01-26T08:54:25+00:00baby546833urn:md5:7130532a4257aaf1e088f33676421f7e
fuck
Message from womenrgr8id@gmail.com
2018-02-11T19:45:33+00:00ammo6818-vandals.uidaho.eduurn:md5:4857fecc692d00a1d73c664ed1132f90
Review comments have been addressed and patch ready to upload to ns-3-dev
Message from fedwar@gmail.com
2018-02-16T09:11:44+00:00Fedwarurn:md5:25a27ffc17f1df5f73077426f1450a33
On 2018/02/11 19:45:33, ammo6818-vandals.uidaho.edu wrote:
> Review comments have been addressed and patch ready to upload to ns-3-dev
Hello,
I'm reporting here the comments from Tom Henderson, which did not go through (he sent them via mail).
This is about the modifications to uan-cw-example.cc and uan-rc-example.cc
(i.e. the #if 0)
----
Sorry for the delay in replying (I just read this for the first time now).
I think that the solution here is to do this:
bool quiet = false;
CommandLine cmd;
cmd.AddValue (quiet, "Run in quiet mode (disable logging)", quiet);
....
if (!quiet)
{
LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
}
This way, you can keep the default behavior (if you prefer) of logging
being on, but if Robert wants to run it in a testing context, he can
pass the --quiet flag.
Message from womenrgr8id@gmail.com
2018-02-18T00:22:52+00:00ammo6818-vandals.uidaho.eduurn:md5:ed88ca1c118f2cdcfcf453cdf0376da1
On 2018/02/16 09:11:44, Fedwar wrote:
> On 2018/02/11 19:45:33, http://ammo6818-vandals.uidaho.edu wrote:
> > Review comments have been addressed and patch ready to upload to ns-3-dev
>
> Hello,
> I'm reporting here the comments from Tom Henderson, which did not go through (he
> sent them via mail).
> This is about the modifications to uan-cw-example.cc and uan-rc-example.cc
>
> (i.e. the #if 0)
>
> ----
>
>
> Sorry for the delay in replying (I just read this for the first time now).
>
>
>
> I think that the solution here is to do this:
>
>
>
> bool quiet = false;
>
>
>
> CommandLine cmd;
>
> cmd.AddValue (quiet, "Run in quiet mode (disable logging)", quiet);
>
> ....
>
>
>
> if (!quiet)
>
> {
>
> LogComponentEnable ("UanCwExample", LOG_LEVEL_ALL);
>
> }
>
>
>
> This way, you can keep the default behavior (if you prefer) of logging
> being on, but if Robert wants to run it in a testing context, he can
> pass the --quiet flag.
change incorporated
Message from unknown
2018-02-18T01:00:43+00:00ammo6818-vandals.uidaho.eduurn:md5:b67ea28ccd26e272dd74ce6c7f6e369a