Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(319)

Issue 337870043: Charles Winston's GSoC code: Chord Semantics

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by chazwins6
Modified:
1 month, 2 weeks ago
Reviewers:
pkx166h, pwm, lilypond-pkx, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Charles Winston's GSoC code: Chord Semantics

Patch Set 1 #

Patch Set 2 : Fixing errors with chord-semantics #

Patch Set 3 : Fixing errors in make doc. #

Total comments: 31
Unified diffs Side-by-side diffs Delta from patch set Stats (+658 lines, -114 lines) Patch
M Documentation/notation/chords.itely View 1 2 3 chunks +33 lines, -9 lines 1 comment Download
M input/regression/chord-name-exceptions.ly View 1 chunk +20 lines, -7 lines 2 comments Download
A input/regression/chord-semantics-additions.ly View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A input/regression/chord-semantics-alterations.ly View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A input/regression/chord-semantics-basic.ly View 1 2 1 chunk +12 lines, -0 lines 1 comment Download
A input/regression/chord-semantics-bass.ly View 1 2 1 chunk +12 lines, -0 lines 1 comment Download
A input/regression/chord-semantics-extensions.ly View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A input/regression/chord-semantics-inversions.ly View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A input/regression/chord-semantics-lowercase-root.ly View 1 2 1 chunk +16 lines, -0 lines 1 comment Download
A input/regression/chord-semantics-name-exceptions.ly View 1 2 1 chunk +28 lines, -0 lines 1 comment Download
A input/regression/chord-semantics-power-chord.ly View 1 2 1 chunk +14 lines, -0 lines 1 comment Download
A input/regression/chord-semantics-removals.ly View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A input/regression/chord-semantics-sus.ly View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M lily/chord-name-engraver.cc View 6 chunks +31 lines, -1 line 0 comments Download
M ly/chord-modifiers-init.ly View 1 chunk +2 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/chord-entry.scm View 1 2 7 chunks +246 lines, -90 lines 11 comments Download
M scm/chord-ignatzek-names.scm View 4 chunks +118 lines, -4 lines 7 comments Download
M scm/chord-name.scm View 1 2 1 chunk +38 lines, -0 lines 5 comments Download
M scm/define-context-properties.scm View 4 chunks +7 lines, -2 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-music-properties.scm View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13
pkx166h
Hello, This fails a make check Processing `./fd/lily-2f531b63.ly' Parsing... Renaming input to: `/home/james/lilypond-git/input/regression/predefined-fretboards.ly' warning: cannot ...
1 year, 6 months ago (2017-11-04 12:29:51 UTC) #1
pkx166h
Charles, I just wanted to make sure you saw my last reply about your patch ...
1 year, 5 months ago (2017-11-23 14:06:37 UTC) #2
chazwins6
Fixing errors with chord-semantics
1 year, 4 months ago (2017-12-29 22:38:54 UTC) #3
chazwins6
On 2017/12/29 22:38:54, chazwins6 wrote: > Fixing errors with chord-semantics This should be working now. ...
1 year, 4 months ago (2017-12-29 22:40:33 UTC) #4
pkx166h
Hello Charles, Thanks for your patch however, this fails make check. It fails on a ...
1 year, 4 months ago (2017-12-30 18:10:53 UTC) #5
chazwins6
Fixing errors in make doc.
9 months, 1 week ago (2018-08-11 14:59:10 UTC) #6
lilypond-pkx
On 2018/08/11 14:59:10, chazwins6 wrote: > Fixing errors in make doc. Fails make check input/regression/chord-names-languages.ly' ...
9 months, 1 week ago (2018-08-12 13:54:08 UTC) #7
chazwins6
On 2018/08/12 13:54:08, lilypond-pkx wrote: > On 2018/08/11 14:59:10, chazwins6 wrote: > > Fixing errors ...
9 months, 1 week ago (2018-08-12 15:56:51 UTC) #8
pwm
Hi Charles, I was thinking about working on MusicXML export for chord symbols, and wondered ...
6 months, 1 week ago (2018-11-10 05:44:23 UTC) #9
pwm
Hi Charles, Today I built and ran 'make check' with your patch applied to current ...
6 months, 1 week ago (2018-11-10 19:44:47 UTC) #10
Carl
On 2018/11/10 05:44:23, pwm wrote: >https://codereview.appspot.com/337870043/diff/40001/Documentation/notation/chords.itely#newcode679 > Documentation/notation/chords.itely:679: represent the structure of the chord. > ...
1 month, 2 weeks ago (2019-04-02 04:14:48 UTC) #11
Carl
On 2018/11/10 19:44:47, pwm wrote: > Hi Charles, Today I built and ran 'make check' ...
1 month, 2 weeks ago (2019-04-02 04:15:44 UTC) #12
Carl
1 month, 2 weeks ago (2019-04-02 16:20:08 UTC) #13
> 
> Thanks for figuring this out.  I'm now working on make check, and will post a
> new patch shortly (I hope).

The new patch is up at https://codereview.appspot.com/568650043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b