Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 331860043: Multiple properties for \override \override-lines markup

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by dak
Modified:
1 week, 3 days ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Multiple properties for \override \override-lines markup This allows giving a list of pairs rather than a single one to the \override and \override-lines markup commands.

Patch Set 1 #

Patch Set 2 : Manually improve \override situation (convert-ly rule depressingly ineffective) #

Total comments: 7

Patch Set 3 : Revert changes in Documentation/snippets, incorporate Thomas Morley's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -257 lines) Patch
M Documentation/de/notation/fretted-strings.itely View 1 2 chunks +13 lines, -22 lines 0 comments Download
M Documentation/de/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/de/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/es/notation/fretted-strings.itely View 1 2 chunks +13 lines, -22 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/es/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/fr/notation/fretted-strings.itely View 1 2 chunks +13 lines, -22 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/fr/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/it/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/it/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/ja/notation/fretted-strings.itely View 1 2 chunks +13 lines, -22 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/ja/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 4 chunks +14 lines, -24 lines 0 comments Download
M Documentation/notation/input.itely View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Documentation/notation/text.itely View 1 1 chunk +1 line, -2 lines 0 comments Download
M input/regression/font-kern.ly View 1 2 chunks +4 lines, -6 lines 0 comments Download
M input/regression/font-name.ly View 1 2 chunks +2 lines, -3 lines 0 comments Download
M input/regression/markup-commands.ly View 1 2 chunks +3 lines, -4 lines 0 comments Download
M input/regression/parenthesize-markup.ly View 1 2 chunks +6 lines, -11 lines 0 comments Download
M input/regression/whiteout.ly View 1 2 chunks +3 lines, -5 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 12 chunks +45 lines, -62 lines 0 comments Download

Messages

Total messages: 7
dak
Manually improve \override situation (convert-ly rule depressingly ineffective)
1 week, 6 days ago (2017-10-08 14:38:32 UTC) #1
thomasmorley651
LGTM Some nits: https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly File Documentation/snippets/keyboard-headword.ly (right): https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31 Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1) (baseline-skip . ...
1 week, 6 days ago (2017-10-08 15:19:44 UTC) #2
dak
https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly File Documentation/snippets/keyboard-headword.ly (right): https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31 Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1) (baseline-skip . 2)) { On ...
1 week, 3 days ago (2017-10-11 10:19:25 UTC) #3
dak
https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly File Documentation/snippets/keyboard-headword.ly (right): https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31 Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1) (baseline-skip . 2)) { On ...
1 week, 3 days ago (2017-10-11 10:26:34 UTC) #4
dak
Revert changes in Documentation/snippets, incorporate Thomas Morley's suggestion
1 week, 3 days ago (2017-10-11 10:35:05 UTC) #5
thomasmorley651
On 2017/10/11 10:19:25, dak wrote: > https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode4026 > scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest . > #t) > ...
1 week, 3 days ago (2017-10-11 21:08:49 UTC) #6
dak
1 week, 3 days ago (2017-10-11 21:14:14 UTC) #7
On 2017/10/11 21:08:49, thomasmorley651 wrote:
> On 2017/10/11 10:19:25, dak wrote:
> 
> >
>
https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
> > scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest
.
> > #t)
> > On 2017/10/08 15:19:44, thomasmorley651 wrote:
> > > Why override_-lines_ here. Don't understand.
> > 
> > Because \override ... { x y z } is translated into
> > { \override ... x \override ... y \override ... z }
> > which is wasteful.
> > 
> > Remember that everything that is called "-lines" in markup really is talking
> > about a markup _list_.  Whether it ends up in lines depends on the usage.
> 
> Ah, ofcourse.

Also known as "this sucks".  At some point of time we might replace -lines with
-list like \markuplines was renamed to \markuplist .

But that's likely to be a large piece of work.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted