Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(917)

Issue 328870043: [plaso] Worked on worker process test coverage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Joachim Metz
Modified:
1 month, 3 weeks ago
Reviewers:
onager
CC:
romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp, jberggren
Visibility:
Public.

Description

[plaso] Worked on worker process test coverage

Patch Set 1 #

Patch Set 2 : Worked on analysis process test coverage #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -258 lines) Patch
M plaso/engine/worker.py View 31 chunks +76 lines, -79 lines 2 comments Download
M plaso/lib/definitions.py View 4 chunks +82 lines, -72 lines 0 comments Download
M plaso/multi_processing/analysis_process.py View 1 12 chunks +27 lines, -25 lines 0 comments Download
M plaso/multi_processing/engine.py View 2 chunks +1 line, -3 lines 0 comments Download
M plaso/multi_processing/psort.py View 4 chunks +3 lines, -5 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 9 chunks +38 lines, -38 lines 0 comments Download
M plaso/storage/fake_storage.py View 1 3 chunks +17 lines, -8 lines 2 comments Download
M plaso/storage/interface.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/analysis/test_lib.py View 1 7 chunks +11 lines, -9 lines 0 comments Download
M tests/engine/worker.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/multi_processing/analysis_process.py View 1 2 chunks +56 lines, -3 lines 0 comments Download
A tests/multi_processing/test_lib.py View 1 1 chunk +69 lines, -0 lines 0 comments Download
M tests/multi_processing/worker_process.py View 1 2 chunks +129 lines, -10 lines 0 comments Download

Messages

Total messages: 5
Joachim Metz
2 months, 1 week ago (2017-07-16 09:07:46 UTC) #1
Joachim Metz
Code updated.
2 months, 1 week ago (2017-07-16 10:24:34 UTC) #2
onager
LGTM, some docstring nits https://codereview.appspot.com/328870043/diff/20001/plaso/engine/worker.py File plaso/engine/worker.py (right): https://codereview.appspot.com/328870043/diff/20001/plaso/engine/worker.py#newcode28 plaso/engine/worker.py:28: The event extraction worker determines ...
1 month, 4 weeks ago (2017-07-25 08:31:47 UTC) #3
Joachim Metz
https://codereview.appspot.com/328870043/diff/20001/plaso/engine/worker.py File plaso/engine/worker.py (right): https://codereview.appspot.com/328870043/diff/20001/plaso/engine/worker.py#newcode28 plaso/engine/worker.py:28: The event extraction worker determines which parser are suitable ...
1 month, 3 weeks ago (2017-07-27 06:55:03 UTC) #4
Joachim Metz
1 month, 3 weeks ago (2017-07-27 07:20:29 UTC) #5
merged via github due to pylint 1.7 linting conflicts

additional changes to fix tests and left over from
https://codereview.appspot.com/320630043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted