Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 320630043: [plaso] Refactored image export tool #160 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by Joachim Metz
Modified:
6 years, 8 months ago
Reviewers:
onager
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Refactored image export tool #160 Depends on: https://codereview.appspot.com/324920043/

Patch Set 1 : Refactored image export tool #160 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -251 lines) Patch
M plaso/cli/helpers/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A plaso/cli/helpers/date_filters.py View 1 chunk +97 lines, -0 lines 0 comments Download
M plaso/cli/helpers/event_filters.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/cli/image_export_tool.py View 12 chunks +89 lines, -141 lines 6 comments Download
M plaso/cli/log2timeline_tool.py View 1 chunk +0 lines, -1 line 0 comments Download
A plaso/cli/time_slices.py View 1 chunk +42 lines, -0 lines 0 comments Download
D plaso/frontend/frontend.py View 1 chunk +0 lines, -49 lines 0 comments Download
A tests/cli/helpers/date_filters.py View 1 chunk +106 lines, -0 lines 0 comments Download
M tests/cli/image_export_tool.py View 4 chunks +6 lines, -18 lines 0 comments Download
A + tests/cli/time_slices.py View 1 chunk +5 lines, -5 lines 0 comments Download
D tests/frontend/frontend.py View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 5
Joachim Metz
6 years, 10 months ago (2017-06-04 16:54:45 UTC) #1
Joachim Metz
Code updated.
6 years, 9 months ago (2017-07-02 08:13:31 UTC) #2
onager
Minor textual nits, LGTM https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_tool.py File plaso/cli/image_export_tool.py (right): https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_tool.py#newcode564 plaso/cli/image_export_tool.py:564: u'Filter based on file name ...
6 years, 9 months ago (2017-07-11 15:40:30 UTC) #3
Joachim Metz
merged via github due to pylint 1.7 linting conflicts
6 years, 8 months ago (2017-07-27 06:48:38 UTC) #4
Joachim Metz
6 years, 8 months ago (2017-07-27 06:51:54 UTC) #5
Message was sent while issue was closed. 
https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_to...
File plaso/cli/image_export_tool.py (right):

https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_to...
plaso/cli/image_export_tool.py:564: u'Filter based on file name extensions. This
option accepts '
On 2017/07/11 15:40:30, onager wrote:
> -based

Done.

https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_to...
plaso/cli/image_export_tool.py:570: u'If the purpose is to find all files given
a certain names '
On 2017/07/11 15:40:30, onager wrote:
> Reword this to be consistent with the extensions and signatures arg
descriptions
> - "Filter on file names..."

Done.

https://codereview.appspot.com/320630043/diff/20001/plaso/cli/image_export_to...
plaso/cli/image_export_tool.py:578: u'Filter based on file format signature
identifiers. This option '
On 2017/07/11 15:40:30, onager wrote:
> -based

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b