Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(492)

Issue 328050043: Change \note markup command to get a duration

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by dak
Modified:
3 months, 1 week ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change \note markup command to get a duration Previously, it used a string. First patch only establishes baseline of issue 5155, second patch is the actual change. Third patch is the result of running scripts/auxiliar/update-with-convert-ly.

Patch Set 1 #

Patch Set 2 : Actual issue 5156 patch #

Patch Set 3 : Run scripts/auxiliar/update-with-convert-ly.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -92 lines) Patch
M Documentation/de/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/text.itely View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/creating-metronome-marks-in-markup-mode.ly View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/new/three-sided-box.ly View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/non-default-tuplet-numbers.ly View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M Documentation/snippets/three-sided-box.ly View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/markup-note.ly View 1 2 1 chunk +29 lines, -29 lines 0 comments Download
M input/regression/markup-note-dot.ly View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/markup-note-grob-style.ly View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/tuplet-number-kneed-beam-horizontal-fit.ly View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-text-different-numbers.ly View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-text-fraction-with-notes.ly View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/tuplet-text-note-appended.ly View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M lily/parser.yy View 1 chunk +23 lines, -3 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +36 lines, -0 lines 0 comments Download
M python/musicexp.py View 1 3 chunks +8 lines, -10 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6
dak
Actual issue 5156 patch
4 months ago (2017-07-16 15:49:28 UTC) #1
dak
Run scripts/auxiliar/update-with-convert-ly.sh
4 months ago (2017-07-16 15:53:03 UTC) #2
thomasmorley651
LGTM Though, wouldn't the rest-markup-command needed to be changed accordingly?
3 months, 3 weeks ago (2017-07-25 10:03:08 UTC) #3
dak
On 2017/07/25 10:03:08, thomasmorley651 wrote: > LGTM > > Though, wouldn't the rest-markup-command needed to ...
3 months, 3 weeks ago (2017-07-25 10:44:09 UTC) #4
dak
On 2017/07/25 10:44:09, dak wrote: > On 2017/07/25 10:03:08, thomasmorley651 wrote: > > LGTM > ...
3 months, 3 weeks ago (2017-07-30 23:36:47 UTC) #5
pkx166h
3 months, 1 week ago (2017-08-14 20:10:00 UTC) #6
Patch counted down please push :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4