Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(3895)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
321310043
: WIP: Make window.inner{width,height} use layout viewport
Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by
ajuma
Modified:
6 years, 4 months ago
Reviewers:
Visibility:
Public.
More Reviews
Description
Make window.inner{width,height} use layout viewport BUG=
Patch Set 1
#
Patch Set 2 : Use visible rect instead of layout viewport
#
Patch Set 3 : Rebased
#
Patch Set 4 : Address comments and update changelogs
#
Patch Set 5 : Address smfr's comment
#
Patch Set 6 : Address smfr's comments
#
Patch Set 7 : Better fix
#
Created:
6 years, 4 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+169 lines, -16 lines
)
Patch
M
LayoutTests/ChangeLog
View
1 chunk
+14 lines, -0 lines
0 comments
Download
M
LayoutTests/fast/dom/iframe-inner-size-scaling.html
View
1
2
3
2 chunks
+5 lines, -2 lines
0 comments
Download
M
LayoutTests/fast/dom/window-inner-size-scaling.html
View
2
2 chunks
+5 lines, -3 lines
0 comments
Download
M
LayoutTests/fast/dom/window-inner-size-scaling-expected.txt
View
1 chunk
+3 lines, -3 lines
0 comments
Download
M
Source/WebCore/ChangeLog
View
1 chunk
+38 lines, -0 lines
0 comments
Download
M
Source/WebCore/page/DOMWindow.cpp
View
1
2
3
4
5
2 chunks
+12 lines, -0 lines
0 comments
Download
M
Source/WebCore/page/FrameView.h
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
Source/WebCore/page/FrameView.cpp
View
1
2
3
4
1 chunk
+11 lines, -1 line
0 comments
Download
M
Source/WebCore/platform/ScrollView.h
View
1
2
3
4
5
1 chunk
+7 lines, -0 lines
0 comments
Download
M
Source/WebCore/platform/ScrollView.cpp
View
1
2
3
4
5
6
2 chunks
+26 lines, -0 lines
0 comments
Download
M
Source/WebCore/platform/ScrollableArea.h
View
1
2
3
4
5
1 chunk
+4 lines, -3 lines
0 comments
Download
M
Source/WebCore/platform/ScrollableArea.cpp
View
1
2
3
4
5
6
1 chunk
+4 lines, -4 lines
0 comments
Download
M
Source/WebCore/platform/ios/ScrollViewIOS.mm
View
1
2
1 chunk
+22 lines, -0 lines
0 comments
Download
M
Source/WebCore/platform/mac/ScrollViewMac.mm
View
1
2
1 chunk
+16 lines, -0 lines
0 comments
Download
Issue 321310043: WIP: Make window.inner{width,height} use layout viewport
Created 6 years, 9 months ago by ajuma
Modified 6 years, 4 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
