Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(342)

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 321310043: WIP: Make window.inner{width,height} use layout viewport
Patch Set: Better fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Download patch
« no previous file with comments | « LayoutTests/fast/dom/window-inner-size-scaling-expected.txt ('k') | Source/WebCore/page/DOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index d25f9c75dd633e14e413c1c7bf25123559b2633c..90c609795692c68198c7e6eb1e65d1354d48ebb9 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,41 @@
+2017-12-06 Ali Juma <ajuma@chromium.org>
+
+ window.innerWidth/height shouldn't change under pinch zoom
+ https://bugs.webkit.org/show_bug.cgi?id=174362
+
+ Reviewed by NOBODY (OOPS!).
+
+ Use the layout viewport rect to compute innerWidth and innerHeight. This makes
+ these values independent of page scale.
+
+ Tests: fast/dom/window-inner-size-scaling.html
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::innerHeight const):
+ (WebCore::DOMWindow::innerWidth const):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::clientToLayoutViewportScaleFactor const):
+ (WebCore::FrameView::layoutViewportToClientScaleFactor const):
+ (WebCore::FrameView::clientToLayoutViewportPoint const):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::horizontalScrollbarIntrusion const):
+ (WebCore::ScrollView::verticalScrollbarIntrusion const):
+ (WebCore::ScrollView::platformWidgetHorizontalScrollbarIntrusion const):
+ (WebCore::ScrollView::platformWidgetVerticalScrollbarIntrusion const):
+ * platform/ScrollView.h:
+ * platform/ScrollableArea.cpp:
+ (WebCore::ScrollableArea::horizontalScrollbarIntrusion const):
+ (WebCore::ScrollableArea::verticalScrollbarIntrusion const):
+ (WebCore::ScrollableArea::scrollbarIntrusion const):
+ * platform/ScrollableArea.h:
+ * platform/ios/ScrollViewIOS.mm:
+ (WebCore::ScrollView::platformWidgetHorizontalScrollbarIntrusion const):
+ (WebCore::ScrollView::platformWidgetVerticalScrollbarIntrusion const):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformWidgetHorizontalScrollbarIntrusion const):
+ (WebCore::ScrollView::platformWidgetVerticalScrollbarIntrusion const):
+
2017-12-04 Youenn Fablet <youenn@apple.com>
Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
« no previous file with comments | « LayoutTests/fast/dom/window-inner-size-scaling-expected.txt ('k') | Source/WebCore/page/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b