Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1135)

Issue 313860043: mt940: Parse only supported tags in _find_swit_tags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by nicoe
Modified:
1 year, 7 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix remark #

Patch Set 3 : fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M mt940/__init__.py View 1 2 1 chunk +11 lines, -6 lines 0 comments Download
M mt940/test.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8
nicoe
1 year, 11 months ago (2016-10-15 17:48:29 UTC) #1
ced
Could you put a description of what was the problem. Also there is a typo ...
1 year, 11 months ago (2016-10-15 19:35:52 UTC) #2
ced
The problem must be reported on https://mt940.b2ck.com/ https://codereview.appspot.com/313860043/diff/1/mt940/test.py File mt940/test.py (right): https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode131 mt940/test.py:131: self.assertEqual(rabo_description( start ...
1 year, 11 months ago (2016-10-24 13:50:34 UTC) #3
nicoe
https://codereview.appspot.com/313860043/diff/1/mt940/test.py File mt940/test.py (right): https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode131 mt940/test.py:131: self.assertEqual(rabo_description( On 2016/10/24 13:50:34, ced wrote: > start rabo_description ...
1 year, 11 months ago (2016-10-25 14:03:19 UTC) #4
nicoe
fix remark
1 year, 11 months ago (2016-10-25 14:03:41 UTC) #5
ced
https://codereview.appspot.com/313860043/diff/1/mt940/__init__.py File mt940/__init__.py (right): https://codereview.appspot.com/313860043/diff/1/mt940/__init__.py#newcode176 mt940/__init__.py:176: next_tag_index = len(description) I find the name should be ...
1 year, 11 months ago (2016-10-25 14:29:47 UTC) #6
nicoe
fix remarks
1 year, 7 months ago (2017-02-21 15:19:11 UTC) #7
ced
1 year, 7 months ago (2017-02-21 16:51:52 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b