Code review - Issue 313860043: mt940: Parse only supported tags in _find_swit_tagshttps://codereview.appspot.com/2017-02-21T16:51:52+00:00rietveld
Message from unknown
2016-10-15T17:48:25+00:00nicoeurn:md5:b4dc20e219bb2a21d08a7c03d608cfd0
Message from nicolas.evrard@b2ck.com
2016-10-15T17:48:29+00:00nicoeurn:md5:ad6378e5be4f28c012a553bd887f8139
Message from cedric.krier@b2ck.com
2016-10-15T19:35:52+00:00cedurn:md5:9f4dfb7074bde2adf60e8d04a47bb731
Could you put a description of what was the problem.
Also there is a typo in title.
Message from cedric.krier@b2ck.com
2016-10-24T13:50:34+00:00cedurn:md5:17770f3da6a668f0d10b7474f9c447cc
The problem must be reported on https://mt940.b2ck.com/
https://codereview.appspot.com/313860043/diff/1/mt940/test.py
File mt940/test.py (right):
https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode131
mt940/test.py:131: self.assertEqual(rabo_description(
start rabo_description on a new line.
https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode137
mt940/test.py:137: 'remi': '/INV/16000291 29.7.2016'})
I think this is wrong. /REMI// means empty remi.
Message from nicolas.evrard@b2ck.com
2016-10-25T14:03:19+00:00nicoeurn:md5:8b52b412d5bfe6145a4fca34465d3102
https://codereview.appspot.com/313860043/diff/1/mt940/test.py
File mt940/test.py (right):
https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode131
mt940/test.py:131: self.assertEqual(rabo_description(
On 2016/10/24 13:50:34, ced wrote:
> start rabo_description on a new line.
Done.
https://codereview.appspot.com/313860043/diff/1/mt940/test.py#newcode137
mt940/test.py:137: 'remi': '/INV/16000291 29.7.2016'})
On 2016/10/24 13:50:34, ced wrote:
> I think this is wrong. /REMI// means empty remi.
The fact is there is no norm about that, using :86: to transmit additional information is just a hack.
The best I could find was https://www.rabobank.com/nl/images/Format_Description_MT940%20_2.4_EN.pdf
Message from unknown
2016-10-25T14:03:39+00:00nicoeurn:md5:daaa509c78d2e8bab9bcb19e715529f0
Message from nicolas.evrard@b2ck.com
2016-10-25T14:03:41+00:00nicoeurn:md5:33efbccc7136031f2eb7178738e1a93d
fix remark
Message from cedric.krier@b2ck.com
2016-10-25T14:29:47+00:00cedurn:md5:dede7d9a1e3b8cfdadf25e5890166545
https://codereview.appspot.com/313860043/diff/1/mt940/__init__.py
File mt940/__init__.py (right):
https://codereview.appspot.com/313860043/diff/1/mt940/__init__.py#newcode176
mt940/__init__.py:176: next_tag_index = len(description)
I find the name should be something like a cursor until it is actually the real next_tag_index.
Message from unknown
2017-02-21T15:19:09+00:00nicoeurn:md5:91e7e449578d9788171b2d5297d1f9a2
Message from nicolas.evrard@b2ck.com
2017-02-21T15:19:11+00:00nicoeurn:md5:3f71eff4640c274627304656818334e2
fix remarks
Message from cedric.krier@b2ck.com
2017-02-21T16:51:52+00:00cedurn:md5:a4c3cb9661613efbeba1639ba4a44d6f
LGTM