Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 303250043: [plaso] Added attribute container identifiers #771

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Joachim Metz
Modified:
5 months, 2 weeks ago
Reviewers:
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added attribute container identifiers #771

Patch Set 1 #

Total comments: 4

Patch Set 2 : Worked on attribute container identifiers #771 #

Total comments: 2

Patch Set 3 : Changes after merge. #

Total comments: 62

Patch Set 4 : Changes after split #

Patch Set 5 : Changes after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -280 lines) Patch
M plaso/analysis/file_hashes.py View 3 chunks +17 lines, -13 lines 0 comments Download
M plaso/analysis/interface.py View 1 2 3 4 15 chunks +116 lines, -130 lines 0 comments Download
M plaso/analysis/nsrlsvr.py View 1 2 3 4 chunks +9 lines, -28 lines 0 comments Download
M plaso/analysis/tagging.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M plaso/analysis/viper.py View 1 2 3 5 chunks +13 lines, -51 lines 0 comments Download
M plaso/analysis/virustotal.py View 1 2 3 5 chunks +62 lines, -58 lines 0 comments Download
A plaso/containers/hashes.py View 1 1 chunk +41 lines, -0 lines 0 comments Download
M tests/storage/test_lib.py View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17
Joachim Metz
1 year, 2 months ago (2016-08-08 19:58:26 UTC) #1
Joachim Metz
https://codereview.appspot.com/303250043/diff/1/plaso/containers/interface.py File plaso/containers/interface.py (right): https://codereview.appspot.com/303250043/diff/1/plaso/containers/interface.py#newcode43 plaso/containers/interface.py:43: self.__identifier__ = AttributeContainerIdentifier() Note to reviewer, I'm not yet ...
1 year, 2 months ago (2016-08-08 20:00:48 UTC) #2
Joachim Metz
https://codereview.appspot.com/303250043/diff/1/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/1/plaso/analysis/interface.py#newcode143 plaso/analysis/interface.py:143: self._event_uuids_by_pathspec = defaultdict(list) TODO: get context if this is ...
1 year, 2 months ago (2016-08-09 05:26:15 UTC) #3
Joachim Metz
https://codereview.appspot.com/303250043/diff/1/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/1/plaso/analysis/interface.py#newcode143 plaso/analysis/interface.py:143: self._event_uuids_by_pathspec = defaultdict(list) On 2016/08/09 05:26:15, Joachim Metz wrote: ...
1 year, 2 months ago (2016-08-10 06:22:26 UTC) #4
Joachim Metz
Code updated.
1 year, 2 months ago (2016-08-11 04:52:45 UTC) #5
Joachim Metz
https://codereview.appspot.com/303250043/diff/20001/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/20001/plaso/analysis/interface.py#newcode142 plaso/analysis/interface.py:142: # the specified type nit: add trailing dot.
1 year, 2 months ago (2016-08-11 04:53:53 UTC) #6
Joachim Metz
https://codereview.appspot.com/303250043/diff/20001/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/20001/plaso/analysis/interface.py#newcode142 plaso/analysis/interface.py:142: # the specified type On 2016/08/11 04:53:53, Joachim Metz ...
1 year, 1 month ago (2016-08-27 09:23:42 UTC) #7
Joachim Metz
Code updated.
1 year, 1 month ago (2016-08-27 09:36:15 UTC) #8
Joachim Metz
Code updated.
1 year, 1 month ago (2016-08-27 15:57:15 UTC) #9
Joachim Metz
Code updated.
1 year ago (2016-09-24 14:30:47 UTC) #10
Joachim Metz
Code updated.
1 year ago (2016-10-16 16:15:36 UTC) #11
onager
https://codereview.appspot.com/303250043/diff/100001/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/100001/plaso/analysis/interface.py#newcode114 plaso/analysis/interface.py:114: resulting digest hash recording to. This doesn't make sense ...
9 months, 1 week ago (2017-01-19 16:46:25 UTC) #12
Joachim Metz
https://codereview.appspot.com/303250043/diff/100001/plaso/analysis/interface.py File plaso/analysis/interface.py (right): https://codereview.appspot.com/303250043/diff/100001/plaso/analysis/interface.py#newcode114 plaso/analysis/interface.py:114: resulting digest hash recording to. Technically "hash analysis" does ...
9 months ago (2017-01-22 15:03:14 UTC) #13
onager
<snip> Is this CL still valid, or have the changes been moved elsewhere? https://codereview.appspot.com/312320043/ has ...
9 months ago (2017-01-24 16:29:23 UTC) #14
onager
<snip> Is this CL still valid, or have the changes been moved elsewhere? https://codereview.appspot.com/312320043/ has ...
9 months ago (2017-01-24 16:29:25 UTC) #15
Joachim Metz
It's in the spreadsheet, as indicated earlier and in the spreadsheet I'm splitting this CL. ...
9 months ago (2017-01-24 21:39:33 UTC) #16
Joachim Metz
6 months, 2 weeks ago (2017-04-06 09:15:08 UTC) #17
for the reviewer no need to review this CL yet
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted