Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19499)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 312320043: [plaso] Added attribute container identifiers #771 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by Joachim Metz
Modified:
7 years ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added attribute container identifiers #771

Patch Set 1 #

Patch Set 2 : Added attribute container identifiers #771 #

Patch Set 3 : Added attribute container identifiers #771 #

Patch Set 4 : Changes after merge #

Total comments: 22

Patch Set 5 : Changes after review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1054 lines, -1117 lines) Patch
M plaso/analysis/interface.py View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M plaso/analysis/tagging.py View 1 chunk +1 line, -0 lines 0 comments Download
M plaso/containers/event_sources.py View 2 chunks +0 lines, -2 lines 0 comments Download
M plaso/containers/events.py View 1 2 3 7 chunks +35 lines, -43 lines 0 comments Download
M plaso/containers/interface.py View 1 2 3 4 3 chunks +90 lines, -17 lines 2 comments Download
M plaso/containers/reports.py View 1 4 chunks +13 lines, -20 lines 0 comments Download
M plaso/output/event_buffer.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M plaso/serializer/json_serializer.py View 1 2 3 4 4 chunks +9 lines, -16 lines 0 comments Download
M plaso/storage/gzip_file.py View 1 2 6 chunks +33 lines, -3 lines 0 comments Download
A plaso/storage/identifiers.py View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M plaso/storage/zip_file.py View 1 2 3 4 61 chunks +376 lines, -491 lines 0 comments Download
M test_data/end_to_end/dynamic.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/json.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/json_line.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/l2tcsv.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/l2ttln.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/end_to_end/rawpy.log View 1 2 3 6 chunks +166 lines, -229 lines 0 comments Download
M test_data/end_to_end/tln.log View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M test_data/pinfo_test.json.plaso View 0 chunks +-1 lines, --1 lines 0 comments Download
M test_data/psort_test.json.plaso View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/containers/events.py View 1 chunk +1 line, -3 lines 0 comments Download
M tests/frontend/preg.py View 2 chunks +10 lines, -5 lines 0 comments Download
M tests/multi_processing/psort.py View 1 chunk +8 lines, -7 lines 0 comments Download
M tests/serializer/json_serializer.py View 1 2 3 5 chunks +2 lines, -8 lines 0 comments Download
M tests/storage/fake_storage.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/storage/gzip_file.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/storage/test_lib.py View 1 2 3 2 chunks +21 lines, -14 lines 0 comments Download
M tests/storage/zip_file.py View 1 2 3 32 chunks +81 lines, -102 lines 0 comments Download
M tools/pinfo_test.py View 1 2 3 4 chunks +14 lines, -9 lines 0 comments Download
M tools/psteal_test.py View 1 2 3 4 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 10
Joachim Metz
7 years, 2 months ago (2017-01-22 14:17:24 UTC) #1
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-22 15:32:44 UTC) #2
Joachim Metz
Code updated.
7 years, 2 months ago (2017-02-08 22:04:27 UTC) #3
Joachim Metz
Code updated.
7 years ago (2017-03-26 10:29:29 UTC) #4
onager
https://codereview.appspot.com/312320043/diff/60001/plaso/containers/interface.py File plaso/containers/interface.py (right): https://codereview.appspot.com/312320043/diff/60001/plaso/containers/interface.py#newcode8 plaso/containers/interface.py:8: """Class that defines the attribute container identifier. -Class that ...
7 years ago (2017-03-29 13:53:27 UTC) #5
Joachim Metz
https://codereview.appspot.com/312320043/diff/60001/plaso/containers/interface.py File plaso/containers/interface.py (right): https://codereview.appspot.com/312320043/diff/60001/plaso/containers/interface.py#newcode8 plaso/containers/interface.py:8: """Class that defines the attribute container identifier. On 2017/03/29 ...
7 years ago (2017-03-30 05:39:03 UTC) #6
Joachim Metz
Code updated.
7 years ago (2017-03-30 05:43:11 UTC) #7
onager
One comment, LGTM https://codereview.appspot.com/312320043/diff/80001/plaso/containers/interface.py File plaso/containers/interface.py (right): https://codereview.appspot.com/312320043/diff/80001/plaso/containers/interface.py#newcode11 plaso/containers/interface.py:11: The value should be unique at ...
7 years ago (2017-04-03 16:27:09 UTC) #8
Joachim Metz
https://codereview.appspot.com/312320043/diff/80001/plaso/containers/interface.py File plaso/containers/interface.py (right): https://codereview.appspot.com/312320043/diff/80001/plaso/containers/interface.py#newcode11 plaso/containers/interface.py:11: The value should be unique at runtime an in ...
7 years ago (2017-04-03 16:34:29 UTC) #9
Joachim Metz
7 years ago (2017-04-03 16:46:15 UTC) #10 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close attrcontids
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b