Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2080)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 291520043: [dfdatetime] Added FAT date time support #1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by Joachim Metz
Modified:
7 years, 10 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfdatetime] Added FAT date time support #1. Depends on: https://codereview.appspot.com/298870043/

Patch Set 1 : Added FAT date time support #1. #

Total comments: 11

Patch Set 2 : Changes after review. #

Total comments: 2

Patch Set 3 : Changes after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -2 lines) Patch
M dfdatetime/fake_time.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A dfdatetime/fat_date_time.py View 1 2 1 chunk +127 lines, -0 lines 0 comments Download
M dfdatetime/filetime.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M dfdatetime/interface.py View 1 2 4 chunks +59 lines, -0 lines 0 comments Download
M dfdatetime/posix_time.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M dfdatetime/time_elements.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A tests/fat_date_time.py View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
M tests/interface.py View 1 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Joachim Metz
8 years ago (2016-04-21 08:43:46 UTC) #1
Joachim Metz
Code updated.
8 years ago (2016-04-21 08:44:22 UTC) #2
onager
https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyFromString(self, time_string): I think "Create" is better than ...
8 years ago (2016-04-28 11:50:34 UTC) #3
Joachim Metz
https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyFromString(self, time_string): IMO Create would imply creating a ...
7 years, 12 months ago (2016-04-29 04:28:02 UTC) #4
Joachim Metz
Code updated.
7 years, 12 months ago (2016-04-29 04:29:43 UTC) #5
onager
https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/291520043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyFromString(self, time_string): On 2016/04/29 04:28:01, Joachim Metz wrote: ...
7 years, 11 months ago (2016-06-01 06:17:30 UTC) #6
Joachim Metz
https://codereview.appspot.com/291520043/diff/40001/dfdatetime/fat_date_time.py File dfdatetime/fat_date_time.py (right): https://codereview.appspot.com/291520043/diff/40001/dfdatetime/fat_date_time.py#newcode22 dfdatetime/fat_date_time.py:22: The FAT date time has no timei zone information ...
7 years, 10 months ago (2016-06-07 05:23:14 UTC) #7
Joachim Metz
Code updated.
7 years, 10 months ago (2016-06-07 05:24:44 UTC) #8
Joachim Metz
Code updated.
7 years, 10 months ago (2016-06-07 05:25:17 UTC) #9
onager
LGTM
7 years, 10 months ago (2016-06-10 04:42:06 UTC) #10
Joachim Metz
7 years, 10 months ago (2016-06-10 04:59:56 UTC) #11 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fat_date_time
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b