Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 298870043: [dfdatetime] Added get plaso timestamp support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by Joachim Metz
Modified:
7 years, 10 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfdatetime] Added copy to micro POSIX timestamp support.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Code clean up. #

Total comments: 4

Patch Set 3 : Changes after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -15 lines) Patch
M dfdatetime/fake_time.py View 1 2 1 chunk +17 lines, -3 lines 0 comments Download
M dfdatetime/filetime.py View 1 2 3 chunks +17 lines, -4 lines 0 comments Download
M dfdatetime/interface.py View 1 2 1 chunk +11 lines, -1 line 0 comments Download
M dfdatetime/posix_time.py View 1 2 2 chunks +14 lines, -5 lines 0 comments Download
M dfdatetime/time_elements.py View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M tests/fake_time.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tests/filetime.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/posix_time.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tests/time_elements.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Joachim Metz
8 years ago (2016-04-20 19:46:30 UTC) #1
Joachim Metz
https://codereview.appspot.com/298870043/diff/1/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/298870043/diff/1/dfdatetime/fake_time.py#newcode20 dfdatetime/fake_time.py:20: """Copies the timestamp to a POSIX timestamps in microseconds. ...
8 years ago (2016-04-20 20:31:02 UTC) #2
Joachim Metz
Code updated.
8 years ago (2016-04-21 06:46:08 UTC) #3
onager
https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyToMicroPosixTimestamp(self): I don't think this is a "PosixTimestamp", ...
7 years, 12 months ago (2016-04-28 11:35:24 UTC) #4
Joachim Metz
https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyToMicroPosixTimestamp(self): Hence "micro POSIX timestamp", what alternative do ...
7 years, 12 months ago (2016-04-29 03:17:00 UTC) #5
onager
https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyToMicroPosixTimestamp(self): On 2016/04/29 03:17:00, Joachim Metz wrote: > ...
7 years, 10 months ago (2016-06-01 06:26:17 UTC) #6
Joachim Metz
https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py File dfdatetime/fake_time.py (right): https://codereview.appspot.com/298870043/diff/20001/dfdatetime/fake_time.py#newcode19 dfdatetime/fake_time.py:19: def CopyToMicroPosixTimestamp(self): As discussed: GetPlasoTimestamp for its temporary purpose.
7 years, 10 months ago (2016-06-07 05:06:40 UTC) #7
Joachim Metz
Code updated.
7 years, 10 months ago (2016-06-07 05:06:58 UTC) #8
onager
LGTM
7 years, 10 months ago (2016-06-10 04:42:43 UTC) #9
Joachim Metz
7 years, 10 months ago (2016-06-10 04:56:16 UTC) #10
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close posixmicro
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b