Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1562)

Issue 29130043: juju: fix minor bug; add bug comment

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by rog
Modified:
6 years ago
Reviewers:
mp+195830, natefinch
Visibility:
Public.

Description

juju: fix minor bug; add bug comment https://code.launchpad.net/~rogpeppe/juju-core/465-juju-fix-split/+merge/195830 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: fix minor bug; add bug comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/conn.go View 1 2 chunks +6 lines, -3 lines 1 comment Download
M juju/conn_test.go View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
6 years ago (2013-11-19 17:18:47 UTC) #1
rog
Please take a look.
6 years ago (2013-11-19 17:26:57 UTC) #2
natefinch
6 years ago (2013-11-19 17:55:18 UTC) #3
LGTM

https://codereview.appspot.com/29130043/diff/20001/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/29130043/diff/20001/juju/conn.go#newcode339
juju/conn.go:339: specParts := strings.SplitN(machineIdSpec, ":", 2)
Ideally I'd like to see this section of the parsing code split into its own
function to be more easily tested.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b