Code review - Issue 29130043: juju: fix minor bug; add bug commenthttps://codereview.appspot.com/2013-11-19T17:55:18+00:00rietveld
Message from unknown
2013-11-19T17:18:42+00:00rogurn:md5:b77f7bf4813177fe31c81308d5f55a01
Message from rogpeppe@gmail.com
2013-11-19T17:18:47+00:00rogurn:md5:6146fefea533d47960f42ff29250f957
Please take a look.
Message from unknown
2013-11-19T17:26:55+00:00rogurn:md5:21a6bc511fba6f95aeb5c1dc6182fdf2
Message from rogpeppe@gmail.com
2013-11-19T17:26:57+00:00rogurn:md5:5a7dc658a3d748e8efeb20927eb77fed
Please take a look.
Message from nate.finch@gmail.com
2013-11-19T17:55:18+00:00natefinchurn:md5:2dc3430005f93eed451d7840a84243a6
LGTM
https://codereview.appspot.com/29130043/diff/20001/juju/conn.go
File juju/conn.go (right):
https://codereview.appspot.com/29130043/diff/20001/juju/conn.go#newcode339
juju/conn.go:339: specParts := strings.SplitN(machineIdSpec, ":", 2)
Ideally I'd like to see this section of the parsing code split into its own function to be more easily tested.