Issue 28950043: Node's remaining energy tracing for visualization in NetAnim

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28950043: Node's remaining energy tracing for visualization in NetAnim

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Evgeny Kalishenko

Modified:
10 years, 4 months ago

Reviewers:
john.abraham.in

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

Node's remaining energy tracing for visualization in NetAnim

Patch Set 1 #

Patch Set 2 : Whitespaces added according to the coding standard after review #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -72 lines)			Patch
M	src/netanim/examples/wireless-animation.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/netanim/model/animation-interface.h	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/netanim/model/animation-interface.cc	View	1	22 chunks	+40 lines, -40 lines	0 comments	Download
M	src/netanim/test/netanim-test.cc	View	1	8 chunks	+23 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

john.abraham.in

Looks good to me , can you take care of any cases where you used ...

10 years, 5 months ago (2013-11-29 18:48:41 UTC) #1

Evgeny Kalishenko

Ok, whitespaces added as a second patch set, diff and xml attached. 2013/11/29 <john.abraham.in@gmail.com> > ...

10 years, 4 months ago (2013-12-10 05:59:34 UTC) #2

john.abraham.in

10 years, 4 months ago (2013-12-10 17:14:48 UTC) #3

On 2013/12/10 05:59:34, ydginster wrote:
> Ok, whitespaces added as a second patch set, diff and xml attached.
> 
> 
> 2013/11/29 <mailto:john.abraham.in@gmail.com>
> 
> > Looks good to me , can you take care of any cases where you used "abc()"
> > instead of "abc ()"?
> >
> > And send me
> > 1. the diff
> > 2. the xml file generated wireless-animation.cc?
> >
> > https://codereview.appspot.com/28950043/
> >
> 
> 
> 
> -- 
> Regards,
> Evgeny Kalishenko

Thanks I pushed the changes
http://code.nsnam.org/ns-3-dev/summary

Expand All Messages | Collapse All Messages