Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(609)

Issue 28950043: Node's remaining energy tracing for visualization in NetAnim

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by Evgeny Kalishenko
Modified:
6 years ago
Reviewers:
john.abraham.in
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Node's remaining energy tracing for visualization in NetAnim

Patch Set 1 #

Patch Set 2 : Whitespaces added according to the coding standard after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -72 lines) Patch
M src/netanim/examples/wireless-animation.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/netanim/model/animation-interface.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/netanim/model/animation-interface.cc View 1 22 chunks +40 lines, -40 lines 0 comments Download
M src/netanim/test/netanim-test.cc View 1 8 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 3
john.abraham.in
Looks good to me , can you take care of any cases where you used ...
6 years ago (2013-11-29 18:48:41 UTC) #1
Evgeny Kalishenko
Ok, whitespaces added as a second patch set, diff and xml attached. 2013/11/29 <john.abraham.in@gmail.com> > ...
6 years ago (2013-12-10 05:59:34 UTC) #2
john.abraham.in
6 years ago (2013-12-10 17:14:48 UTC) #3
On 2013/12/10 05:59:34, ydginster wrote:
> Ok, whitespaces added as a second patch set, diff and xml attached.
> 
> 
> 2013/11/29 <mailto:john.abraham.in@gmail.com>
> 
> > Looks good to me , can you take care of any cases where you used "abc()"
> > instead of "abc ()"?
> >
> > And send me
> > 1. the diff
> > 2. the xml file generated wireless-animation.cc?
> >
> > https://codereview.appspot.com/28950043/
> >
> 
> 
> 
> -- 
> Regards,
> Evgeny Kalishenko

Thanks I pushed the changes
http://code.nsnam.org/ns-3-dev/summary
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b