Issue 26530043: Improve charm test venv creation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26530043: Improve charm test venv creation.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by frankban

Modified:
10 years, 5 months ago

Reviewers:
mp+195199, gary.poster

Visibility:
Public.

Description

Improve charm test venv creation. Also added missing SYSDEP. https://code.launchpad.net/~frankban/charms/precise/juju-gui/venv-fixes/+merge/195199 (do not edit description out of merge proposal)

Patch Set 2 : Improve charm test venv creation. #

Total comments: 2

Patch Set 3 : Improve charm test venv creation. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	Makefile	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	revision	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/00-setup	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM with consideration of comment. https://codereview.appspot.com/26530043/diff/20001/tests/00-setup File tests/00-setup (right): https://codereview.appspot.com/26530043/diff/20001/tests/00-setup#newcode35 tests/00-setup:35: [ $retcode -eq 0 ...

10 years, 5 months ago (2013-11-14 11:57:56 UTC) #3

frankban

10 years, 5 months ago (2013-11-14 12:34:28 UTC) #4

*** Submitted:

Improve charm test venv creation.

Also added missing SYSDEP.

R=gary.poster
CC=
https://codereview.appspot.com/26530043

https://codereview.appspot.com/26530043/diff/20001/tests/00-setup
File tests/00-setup (right):

https://codereview.appspot.com/26530043/diff/20001/tests/00-setup#newcode35
tests/00-setup:35: [ $retcode -eq 0 ] && touch $ACTIVATE || rm -f $ACTIVATE
On 2013/11/14 11:57:56, gary.poster wrote:
> The only downside to this is that, since the $ACTIVATE is removed, you can't
use
> it to diagnose issues.  What would you think of touching $TEST_REQUIREMENTS in
> the failure case, instead?

Great suggestion! Done.

Expand All Messages | Collapse All Messages