Code review - Issue 26530043: Improve charm test venv creation.https://codereview.appspot.com/2013-11-14T12:34:28+00:00rietveld
Message from unknown
2013-11-14T10:57:25+00:00frankbanurn:md5:d4d861dc09da83881c4756f5207099a6
Message from francesco.banconi@canonical.com
2013-11-14T10:57:29+00:00frankbanurn:md5:a9aa26f99f5e32aed0f6728eaba8c936
Please take a look.
Message from unknown
2013-11-14T11:25:51+00:00frankbanurn:md5:38f670f6fe8cd0fa76162be7d655b212
Message from francesco.banconi@canonical.com
2013-11-14T11:25:54+00:00frankbanurn:md5:056e7b70e00d022185c49058106e4756
Please take a look.
Message from gary.poster@canonical.com
2013-11-14T11:57:56+00:00gary.posterurn:md5:d5409e63386c49c09bf46ebd9362d79c
LGTM with consideration of comment.
https://codereview.appspot.com/26530043/diff/20001/tests/00-setup
File tests/00-setup (right):
https://codereview.appspot.com/26530043/diff/20001/tests/00-setup#newcode35
tests/00-setup:35: [ $retcode -eq 0 ] && touch $ACTIVATE || rm -f $ACTIVATE
The only downside to this is that, since the $ACTIVATE is removed, you can't use it to diagnose issues. What would you think of touching $TEST_REQUIREMENTS in the failure case, instead?
Message from unknown
2013-11-14T12:30:14+00:00frankbanurn:md5:c9b092678fa7cd1abdd48245e6a4c4cb
Message from francesco.banconi@canonical.com
2013-11-14T12:34:28+00:00frankbanurn:md5:11d9284097de3cba641c992b59c8f47f
*** Submitted:
Improve charm test venv creation.
Also added missing SYSDEP.
R=gary.poster
CC=
https://codereview.appspot.com/26530043
https://codereview.appspot.com/26530043/diff/20001/tests/00-setup
File tests/00-setup (right):
https://codereview.appspot.com/26530043/diff/20001/tests/00-setup#newcode35
tests/00-setup:35: [ $retcode -eq 0 ] && touch $ACTIVATE || rm -f $ACTIVATE
On 2013/11/14 11:57:56, gary.poster wrote:
> The only downside to this is that, since the $ACTIVATE is removed, you can't use
> it to diagnose issues. What would you think of touching $TEST_REQUIREMENTS in
> the failure case, instead?
Great suggestion! Done.