Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(782)

Issue 26220043: Better separation between BaseChildWatcher and its subclasses (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by ayba
Modified:
9 years ago
Reviewers:
GvR
CC:
haypo_gmail
Visibility:
Public.

Description

Better separation between BaseChildWatcher and its subclasses BaseChildWatcher now cares only about registering the SIGCHLD handler. The _callbacks list is moved into the subclasses.

Patch Set 1 #

Total comments: 6

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -41 lines) Patch
M asyncio/unix_events.py View 1 9 chunks +41 lines, -27 lines 0 comments Download
M tests/test_events.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/test_unix_events.py View 1 8 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 5
GvR
https://codereview.appspot.com/26220043/diff/1/asyncio/unix_events.py File asyncio/unix_events.py (right): https://codereview.appspot.com/26220043/diff/1/asyncio/unix_events.py#newcode443 asyncio/unix_events.py:443: def attach_loop(self, loop): I wonder if these two pieces ...
9 years ago (2013-11-13 20:00:02 UTC) #1
ayba
On 2013/11/13 20:00:02, GvR wrote: > https://codereview.appspot.com/26220043/diff/1/asyncio/unix_events.py#newcode443 > asyncio/unix_events.py:443: def attach_loop(self, loop): > I wonder ...
9 years ago (2013-11-13 20:43:40 UTC) #2
GvR
We have reached a local optimum of maximum improvement with minimal changes. I will commit ...
9 years ago (2013-11-13 23:44:55 UTC) #3
ayba
On 2013/11/13 23:44:55, GvR wrote: > We have reached a local optimum of maximum improvement ...
9 years ago (2013-11-14 06:37:20 UTC) #4
ayba
9 years ago (2013-11-14 07:22:05 UTC) #5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b