Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

Issue 26480043: remove global state in ChildWatcher tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by ayba
Modified:
10 years, 4 months ago
Reviewers:
GvR
Visibility:
Public.

Description

remove global state in ChildWatcher tests

Patch Set 1 #

Patch Set 2 : with a namedtuple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -244 lines) Patch
M tests/test_unix_events.py View 1 36 chunks +176 lines, -244 lines 0 comments Download

Messages

Total messages: 3
GvR
This looks great -- I'm glad my idea was workable. I have one more suggestion: ...
10 years, 4 months ago (2013-11-14 18:32:14 UTC) #1
ayba
with the named tuple it is fine now!
10 years, 4 months ago (2013-11-14 22:50:59 UTC) #2
GvR
10 years, 4 months ago (2013-11-15 00:14:33 UTC) #3
Thanks! I moved the named tuple definition to the global level and committed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b