Issue 26480043: remove global state in ChildWatcher tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26480043: remove global state in ChildWatcher tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by ayba

Modified:
11 years, 4 months ago

Reviewers:
GvR

Visibility:
Public.

remove global state in ChildWatcher tests

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -244 lines)			Patch
	M	tests/test_unix_events.py	View	1	36 chunks	+176 lines, -244 lines	0 comments	Download

Total messages: 3

GvR

This looks great -- I'm glad my idea was workable. I have one more suggestion: ...

11 years, 4 months ago (2013-11-14 18:32:14 UTC) #1

GvR

11 years, 4 months ago (2013-11-15 00:14:33 UTC) #3

Thanks! I moved the named tuple definition to the global level and committed.