Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1120)

Issue 249960043: GSoC 2015 - MidTerm Milestone - Carrier Aggregation

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by dabrignani
Modified:
3 years, 1 month ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This is code review request for GSoC 2015, LTE CA Support. This code is related to the first 5 weeks of the project (see https://www.nsnam.org/wiki/GSOC2015LTECA) This code review is incremental wrt https://codereview.appspot.com/241320043/

Patch Set 1 #

Total comments: 64
Unified diffs Side-by-side diffs Delta from patch set Stats (+2646 lines, -1093 lines) Patch
M src/lte/examples/lena-simple.cc View 2 chunks +3 lines, -3 lines 2 comments Download
M src/lte/examples/wscript View 1 chunk +3 lines, -0 lines 3 comments Download
A src/lte/helper/cc-helper.h View 1 chunk +137 lines, -0 lines 8 comments Download
A src/lte/helper/cc-helper.cc View 1 chunk +166 lines, -0 lines 4 comments Download
M src/lte/helper/lte-helper.h View 19 chunks +70 lines, -41 lines 6 comments Download
M src/lte/helper/lte-helper.cc View 27 chunks +334 lines, -213 lines 13 comments Download
M src/lte/helper/phy-stats-calculator.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M src/lte/helper/radio-bearer-stats-calculator.cc View 1 chunk +554 lines, -554 lines 2 comments Download
A src/lte/model/component-carrier.h View 1 chunk +174 lines, -0 lines 9 comments Download
A src/lte/model/component-carrier.cc View 1 chunk +255 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier-ue.h View 1 chunk +173 lines, -0 lines 3 comments Download
A src/lte/model/component-carrier-ue.cc View 1 chunk +255 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 6 chunks +38 lines, -5 lines 2 comments Download
M src/lte/model/lte-enb-phy.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-enb-phy.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-enb-rrc.h View 13 chunks +27 lines, -20 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 21 chunks +104 lines, -30 lines 4 comments Download
M src/lte/model/lte-harq-phy.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-rrc-sap.cc View 1 chunk +22 lines, -22 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 chunk +1 line, -0 lines 2 comments Download
M src/lte/model/lte-ue-net-device.h View 5 chunks +12 lines, -0 lines 2 comments Download
M src/lte/model/lte-ue-net-device.cc View 7 chunks +36 lines, -5 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 5 chunks +22 lines, -3 lines 2 comments Download
M src/lte/model/lte-ue-rrc.cc View 78 chunks +219 lines, -181 lines 2 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/test/test-asn1-encoding.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/lte/wscript View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dabrignani
This is code review request for GSoC 2015, LTE CA Support. This code is related ...
3 years, 2 months ago (2015-06-26 16:37:38 UTC) #1
buherman
Hi Danilo, I have some small comments to your code. I find that you commented ...
3 years, 2 months ago (2015-07-01 13:53:35 UTC) #2
dabrignani
Hi Buherman, I try to reply to all your comments. I hope you will found ...
3 years, 2 months ago (2015-07-02 14:12:30 UTC) #3
Marco Miozzo
Hi Danilo, very good work, and many thanks to Budiarto also for the valuable review. ...
3 years, 2 months ago (2015-07-02 14:47:11 UTC) #4
dabrignani
Hi Marco, thanks for the comments. Regarding the pa value, I will check the possible ...
3 years, 2 months ago (2015-07-02 15:39:02 UTC) #5
gawlowicz.p
Hi Danilo, First of all, it is very good work. I am looking forward to ...
3 years, 2 months ago (2015-07-05 00:25:09 UTC) #6
dabrignani
Dear Piotr, thanks for your comments. I tried to answer to all. Let me know ...
3 years, 2 months ago (2015-07-05 11:12:49 UTC) #7
dabrignani
3 years, 2 months ago (2015-07-05 11:12:53 UTC) #8
Dear Piotr,

thanks for your comments.
I tried to answer to all.

Let me know if the replies are satisfactory.

Best,
Danilo
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b