Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1280)

Issue 241320043: RrcConnectionReconfiguration Message - CA support

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by dabrignani
Modified:
4 years, 3 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This is code review request for GSoC 2015, LTE CA Support. This code is related to the first 2 weeks of the project (see https://www.nsnam.org/wiki/GSOC2015LTECA) I implemented the new version of RrcConnectionReconfiguration Message, needed to activate the Secondary Carrier Components (SCcs). I coded the new messages for ASN1 header, a mandatory step to simulate the Rrc Real protocol. Moreover, I implemented a first module connected to RRC that deal with the enable procedure for the Cc. Basically, extending this module it is possible to decide when and for which UE enable the SCcs. This module (Carrier Component Selection - CCS) it is inspired to the handover and ffr module implemented in the simulator.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7916 lines, -6397 lines) Patch
M src/lte/helper/lte-helper.h View 6 chunks +32 lines, -0 lines 2 comments Download
M src/lte/helper/lte-helper.cc View 7 chunks +38 lines, -0 lines 0 comments Download
M src/lte/model/lte-asn1-header.h View 4 chunks +21 lines, -0 lines 0 comments Download
M src/lte/model/lte-asn1-header.cc View 4 chunks +12 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccs-algorithm.h View 1 chunk +111 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccs-algorithm.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A src/lte/model/lte-componentcarrier-management-sap.h View 1 chunk +194 lines, -0 lines 0 comments Download
A src/lte/model/lte-componentcarrier-management-sap.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 8 chunks +34 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 9 chunks +44 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-header.h View 5 chunks +24 lines, -1 line 0 comments Download
M src/lte/model/lte-rrc-header.cc View 3 chunks +7011 lines, -6391 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 3 chunks +114 lines, -2 lines 0 comments Download
A src/lte/model/no-op-ccs-algorithm.h View 1 chunk +79 lines, -0 lines 2 comments Download
A src/lte/model/no-op-ccs-algorithm.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M src/lte/wscript View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2
buherman
Hi Danilo, A couple of minor comments. -budi- https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h File src/lte/helper/lte-helper.h (right): https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h#newcode621 src/lte/helper/lte-helper.h:621: void ...
4 years, 3 months ago (2015-07-01 13:55:19 UTC) #1
dabrignani
4 years, 3 months ago (2015-07-02 14:01:11 UTC) #2
Hi Buherman,

Thanks for your comments, I correct what you pointed out.

Best,
Danilo

https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h
File src/lte/helper/lte-helper.h (right):

https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h#n...
src/lte/helper/lte-helper.h:621: void PrepareRrcCa (Ptr<NetDevice> ue,
Ptr<NetDevice> enb);
On 2015/07/01 13:55:18, buherman wrote:
> This method is not implemented in the .cc file.

I just forget to delete the prototype, it was part of a previous version of the
code. I will delete that line immediately. 
Acknowledged.

https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algor...
File src/lte/model/no-op-ccs-algorithm.h (right):

https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algor...
src/lte/model/no-op-ccs-algorithm.h:35: * Selecting this Component carrier
selectionalgorithm is equivalent to disabling automatic
On 2015/07/01 13:55:18, buherman wrote:
> selectionalgorithm -> selection algorithm

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b