Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2360)

Issue 247160044: UI for ticket create and modify

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by vipul
Modified:
4 years, 3 months ago
Reviewers:
sksaurabhkathpalia, thomas.j.waldmann
Visibility:
Public.

Description

UI for ticket create and modify Reduced font size and changed the layout in both create and modify view. screenshots: http://i.imgur.com/jyKlC3K.png http://i.imgur.com/poVia4D.png http://i.imgur.com/x8ej8GE.png

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -77 lines) Patch
M MoinMoin/static/css/ticket.css View 5 chunks +16 lines, -8 lines 0 comments Download
M MoinMoin/static/img/radiobutton.png View Binary file 0 comments Download
M MoinMoin/templates/ticket/base.html View 6 chunks +19 lines, -31 lines 8 comments Download
M MoinMoin/templates/ticket/modify.html View 2 chunks +24 lines, -14 lines 0 comments Download
M MoinMoin/templates/ticket/submit.html View 1 chunk +36 lines, -24 lines 5 comments Download

Messages

Total messages: 4
sksaurabhkathpalia
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html File MoinMoin/templates/ticket/submit.html (right): https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode13 MoinMoin/templates/ticket/submit.html:13: <div style="clear:both;"></div> Why empty div here? https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode35 MoinMoin/templates/ticket/submit.html:35: <div ...
4 years, 4 months ago (2015-06-22 13:25:00 UTC) #1
vipul
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html File MoinMoin/templates/ticket/submit.html (right): https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode13 MoinMoin/templates/ticket/submit.html:13: <div style="clear:both;"></div> On 2015/06/22 13:25:00, sksaurabhkathpalia wrote: > Why ...
4 years, 4 months ago (2015-06-22 13:35:55 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html File MoinMoin/templates/ticket/base.html (left): https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode72 MoinMoin/templates/ticket/base.html:72: {%- endif %} so, this is just gone? https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode99 ...
4 years, 3 months ago (2015-06-25 20:40:07 UTC) #3
vipul
4 years, 3 months ago (2015-06-25 20:56:38 UTC) #4
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
File MoinMoin/templates/ticket/base.html (left):

https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
MoinMoin/templates/ticket/base.html:72: {%- endif %}
On 2015/06/25 20:40:07, Thomas.J.Waldmann wrote:
> so, this is just gone?

as the subscribe button is now provided alongside other metadata fields, it had
to be removed from side panel and header in ticket view

https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
MoinMoin/templates/ticket/base.html:99: </li>
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so, this is just gone?

same as previous comment

https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
MoinMoin/templates/ticket/base.html:127: </div>
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so, this is just gone?

moved this content inside "ticket_content" in modify.html and submit.html. So
these, blocks are not needed

https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
File MoinMoin/templates/ticket/base.html (right):

https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/bas...
MoinMoin/templates/ticket/base.html:52: {% endmacro %}
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so you define subscribe macro here, where do you call it?

I've created a macro for "subscribe" and used it in the ticket view. So now,
there is a subscribe button alongside other meta fields. Otherwise, it used to
be under "User Action" option
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b