Code review - Issue 247160044: UI for ticket create and modifyhttps://codereview.appspot.com/2015-06-25T20:56:38+00:00rietveld
Message from unknown
2015-06-21T21:34:33+00:00vipulurn:md5:52667b48c9583aa420f586696183548b
Message from sksaurabhkathpalia@gmail.com
2015-06-22T13:25:00+00:00sksaurabhkathpaliaurn:md5:438bd00f67a31706ea965438ff248872
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html
File MoinMoin/templates/ticket/submit.html (right):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode13
MoinMoin/templates/ticket/submit.html:13: <div style="clear:both;"></div>
Why empty div here?
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode35
MoinMoin/templates/ticket/submit.html:35: <div style="clear:both;"></div>
here also
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode46
MoinMoin/templates/ticket/submit.html:46: <div style="clear:both;"></div>
here also
Message from vipul.sharma20@gmail.com
2015-06-22T13:35:55+00:00vipulurn:md5:eddac3db5399d224782fff0f12f26079
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html
File MoinMoin/templates/ticket/submit.html (right):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode13
MoinMoin/templates/ticket/submit.html:13: <div style="clear:both;"></div>
On 2015/06/22 13:25:00, sksaurabhkathpalia wrote:
> Why empty div here?
I've added the empty divs with "clear:both" few places here to clear the float.
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/submit.html#newcode35
MoinMoin/templates/ticket/submit.html:35: <div style="clear:both;"></div>
On 2015/06/22 13:25:00, sksaurabhkathpalia wrote:
> here also
same as above
Message from Thomas.J.Waldmann@gmail.com
2015-06-25T20:40:07+00:00Thomas.J.Waldmannurn:md5:3e2aa77ee87fe80573ea64816af65c6d
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html
File MoinMoin/templates/ticket/base.html (left):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode72
MoinMoin/templates/ticket/base.html:72: {%- endif %}
so, this is just gone?
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode99
MoinMoin/templates/ticket/base.html:99: </li>
so, this is just gone?
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode127
MoinMoin/templates/ticket/base.html:127: </div>
so, this is just gone?
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html
File MoinMoin/templates/ticket/base.html (right):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#newcode52
MoinMoin/templates/ticket/base.html:52: {% endmacro %}
so you define subscribe macro here, where do you call it?
Message from vipul.sharma20@gmail.com
2015-06-25T20:56:38+00:00vipulurn:md5:4720e5001dfeaa6da32bb944f093770b
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html
File MoinMoin/templates/ticket/base.html (left):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode72
MoinMoin/templates/ticket/base.html:72: {%- endif %}
On 2015/06/25 20:40:07, Thomas.J.Waldmann wrote:
> so, this is just gone?
as the subscribe button is now provided alongside other metadata fields, it had to be removed from side panel and header in ticket view
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode99
MoinMoin/templates/ticket/base.html:99: </li>
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so, this is just gone?
same as previous comment
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#oldcode127
MoinMoin/templates/ticket/base.html:127: </div>
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so, this is just gone?
moved this content inside "ticket_content" in modify.html and submit.html. So these, blocks are not needed
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html
File MoinMoin/templates/ticket/base.html (right):
https://codereview.appspot.com/247160044/diff/1/MoinMoin/templates/ticket/base.html#newcode52
MoinMoin/templates/ticket/base.html:52: {% endmacro %}
On 2015/06/25 20:40:06, Thomas.J.Waldmann wrote:
> so you define subscribe macro here, where do you call it?
I've created a macro for "subscribe" and used it in the ticket view. So now, there is a subscribe button alongside other meta fields. Otherwise, it used to be under "User Action" option