Code review - Issue 241320043: RrcConnectionReconfiguration Message - CA supporthttps://codereview.appspot.com/2015-07-02T14:01:11+00:00rietveld
Message from unknown
2015-06-10T11:31:12+00:00dabrignaniurn:md5:8ea7f6ffa55b775e3f4dba440bfff1d9
Message from budiarto.herman@magister.fi
2015-07-01T13:55:19+00:00buhermanurn:md5:5c543c91150de05edec65f37a1588ef2
Hi Danilo,
A couple of minor comments.
-budi-
https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h
File src/lte/helper/lte-helper.h (right):
https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h#newcode621
src/lte/helper/lte-helper.h:621: void PrepareRrcCa (Ptr<NetDevice> ue, Ptr<NetDevice> enb);
This method is not implemented in the .cc file.
https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algorithm.h
File src/lte/model/no-op-ccs-algorithm.h (right):
https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algorithm.h#newcode35
src/lte/model/no-op-ccs-algorithm.h:35: * Selecting this Component carrier selectionalgorithm is equivalent to disabling automatic
selectionalgorithm -> selection algorithm
Message from dabrignani@gmail.com
2015-07-02T14:01:11+00:00dabrignaniurn:md5:7f448a982a4f663f27ed17ce8ea1d64d
Hi Buherman,
Thanks for your comments, I correct what you pointed out.
Best,
Danilo
https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h
File src/lte/helper/lte-helper.h (right):
https://codereview.appspot.com/241320043/diff/1/src/lte/helper/lte-helper.h#newcode621
src/lte/helper/lte-helper.h:621: void PrepareRrcCa (Ptr<NetDevice> ue, Ptr<NetDevice> enb);
On 2015/07/01 13:55:18, buherman wrote:
> This method is not implemented in the .cc file.
I just forget to delete the prototype, it was part of a previous version of the code. I will delete that line immediately.
Acknowledged.
https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algorithm.h
File src/lte/model/no-op-ccs-algorithm.h (right):
https://codereview.appspot.com/241320043/diff/1/src/lte/model/no-op-ccs-algorithm.h#newcode35
src/lte/model/no-op-ccs-algorithm.h:35: * Selecting this Component carrier selectionalgorithm is equivalent to disabling automatic
On 2015/07/01 13:55:18, buherman wrote:
> selectionalgorithm -> selection algorithm
Done.