Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11093)

Issue 235010043: absolute pitch entry: accept an offset octave

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 12 months ago by Keith
Modified:
8 years, 11 months ago
Reviewers:
paul, dak, pls, c_sorensen, Dan Eble, dan, lemzwerg, Trevor Daniels, wl, valentin, pwm, pacovila, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

absolute pitch entry: accept an offset octave; issue 4366

Patch Set 1 #

Total comments: 1

Patch Set 2 : take a starting pitch, use only its octave #

Total comments: 1

Patch Set 3 : idempotency #

Total comments: 1

Patch Set 4 : alphabetize #

Patch Set 5 : allow fixed to apply to \chordmode #

Patch Set 6 : leave the tutorial alone #

Total comments: 7

Patch Set 7 : require a reference pitch for \fixed c {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -23 lines) Patch
M Documentation/learning/common-notation.itely View 2 chunks +22 lines, -8 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 chunk +26 lines, -13 lines 0 comments Download
A input/regression/relative.ly View 1 chunk +12 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 2 chunks +15 lines, -1 line 0 comments Download
M scm/define-music-types.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 55
dak
https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly#newcode36 ly/music-functions-init.ly:36: ((integer?) ly:music?) Why use a number here instead of ...
8 years, 12 months ago (2015-05-03 06:28:43 UTC) #1
dak
On 2015/05/03 06:28:43, dak wrote: > https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly > File ly/music-functions-init.ly (right): > > https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly#newcode36 > ...
8 years, 12 months ago (2015-05-03 06:33:12 UTC) #2
lemzwerg
Nice! However, I second David's concern: Please use \absolute <pitch> instead of \absolute <number>
8 years, 12 months ago (2015-05-03 07:18:18 UTC) #3
Trevor Daniels
I'm in favour of a change like this, but I'd prefer the syntax and options ...
8 years, 12 months ago (2015-05-03 08:20:03 UTC) #4
dak
On 2015/05/03 08:20:03, Trevor Daniels wrote: > I'm in favour of a change like this, ...
8 years, 12 months ago (2015-05-03 09:02:51 UTC) #5
Dan Eble
If people don't like numbers (I'm with you) are there any other feasible ways to ...
8 years, 12 months ago (2015-05-03 13:23:15 UTC) #6
pwm
On 2015/05/03 13:23:15, Dan Eble wrote: > If people don't like numbers (I'm with you) ...
8 years, 12 months ago (2015-05-03 16:27:58 UTC) #7
Trevor Daniels
On 2015/05/03 09:02:51, dak wrote: > However, I _think_ that your comment would suggest \absolute ...
8 years, 12 months ago (2015-05-03 16:42:02 UTC) #8
dak
On 2015/05/03 16:27:58, pwm wrote: > On 2015/05/03 13:23:15, Dan Eble wrote: > > If ...
8 years, 12 months ago (2015-05-03 20:04:28 UTC) #9
dak
On 2015/05/03 16:42:02, Trevor Daniels wrote: > Yes, in Keith's and my model \relative sets ...
8 years, 12 months ago (2015-05-03 20:25:22 UTC) #10
Trevor Daniels
On 2015/05/03 20:25:22, dak wrote: > Again: I don't think that this was Keith's proposal. ...
8 years, 12 months ago (2015-05-03 21:02:44 UTC) #11
pwm
On 2015/05/03 20:04:28, dak wrote: > > There is no such thing as '' or ...
8 years, 12 months ago (2015-05-03 21:09:26 UTC) #12
Dan Eble
On 2015/05/03 20:25:22, dak wrote: > I still would recommend > just using c to ...
8 years, 12 months ago (2015-05-03 23:49:50 UTC) #13
Keith
On 2015/05/03 08:20:03, Trevor Daniels wrote: > I'd prefer the syntax and options to parallel ...
8 years, 12 months ago (2015-05-04 03:10:44 UTC) #14
Keith
On 2015/05/03 20:25:22, dak wrote: > On 2015/05/03 16:42:02, Trevor Daniels wrote: > > I ...
8 years, 12 months ago (2015-05-04 03:51:00 UTC) #15
Keith
On 2015/05/03 16:42:02, Trevor Daniels wrote: > > a continuous scale would be \relativeOctave { ...
8 years, 12 months ago (2015-05-04 03:59:05 UTC) #16
lemzwerg
I also favour \absolute c'' { ... } in Keith's original interpretation. However, I suggest ...
8 years, 12 months ago (2015-05-04 04:11:13 UTC) #17
dak
k-ohara5a5a@oco.net writes: > On 2015/05/03 20:25:22, dak wrote: >> On 2015/05/03 16:42:02, Trevor Daniels wrote: ...
8 years, 12 months ago (2015-05-04 10:25:19 UTC) #18
valentin_villenave.net
On Mon, May 4, 2015 at 12:25 PM, <dak@gnu.org> wrote: > This kind of addition ...
8 years, 12 months ago (2015-05-05 06:58:12 UTC) #19
dak
Valentin Villenave <valentin@villenave.net> writes: > On Mon, May 4, 2015 at 12:25 PM, <dak@gnu.org> wrote: ...
8 years, 12 months ago (2015-05-05 10:48:32 UTC) #20
Keith
On Mon, 04 May 2015 23:58:12 -0700, Valentin Villenave <valentin@villenave.net> wrote: > Speaking as someone ...
8 years, 12 months ago (2015-05-06 05:10:49 UTC) #21
pacovila
2015-05-05 8:58 GMT+02:00 Valentin Villenave <valentin@villenave.net>: > On Mon, May 4, 2015 at 12:25 PM, ...
8 years, 12 months ago (2015-05-06 09:58:25 UTC) #22
c_sorensen
On 5/5/15 11:10 PM, "Keith OHara" <k-ohara5a5a@oco.net> wrote: >On Mon, 04 May 2015 23:58:12 -0700, ...
8 years, 12 months ago (2015-05-06 14:48:30 UTC) #23
Keith
On 2015/05/06 09:58:25, pacovila wrote: > > I love \relative mode because it fits perfectly ...
8 years, 12 months ago (2015-05-06 15:53:01 UTC) #24
wl_gnu.org
> Probably the best name is \octave, which was used for something > similar > ...
8 years, 12 months ago (2015-05-06 15:57:21 UTC) #25
Trevor Daniels
On 2015/05/06 15:57:21, wl_gnu.org wrote: > > Probably the best name is \octave, which was ...
8 years, 12 months ago (2015-05-06 16:40:55 UTC) #26
dak
Werner LEMBERG <wl@gnu.org> writes: >> Probably the best name is \octave, which was used for ...
8 years, 12 months ago (2015-05-06 18:45:08 UTC) #27
simon.albrecht
Hello, I’d also vote for the three-ways distinction relative/absolute/octave as put by Trevor. Am 06.05.2015 ...
8 years, 12 months ago (2015-05-06 21:53:09 UTC) #28
dan_faithful.be
On May 6, 2015, at 14:43 , David Kastrup <dak@gnu.org> wrote: > > Neither \octave ...
8 years, 12 months ago (2015-05-07 01:33:00 UTC) #29
paul_paulwmorris.com
> On May 6, 2015, at 10:48 AM, Carl Sorensen <c_sorensen@byu.edu> wrote: > > So, ...
8 years, 12 months ago (2015-05-07 06:05:07 UTC) #30
dak
Dan Eble <dan@faithful.be> writes: > On May 6, 2015, at 14:43 , David Kastrup <dak@gnu.org> ...
8 years, 12 months ago (2015-05-07 09:07:31 UTC) #31
pls
On 06.05.2015, at 20:43, David Kastrup <dak@gnu.org> wrote: > Werner LEMBERG <wl@gnu.org> writes: > >>> ...
8 years, 12 months ago (2015-05-07 11:07:03 UTC) #32
dak
Paul Morris <paul@paulwmorris.com> writes: >> On May 6, 2015, at 10:48 AM, Carl Sorensen <c_sorensen@byu.edu> ...
8 years, 12 months ago (2015-05-07 11:38:16 UTC) #33
paul_paulwmorris.com
> On May 7, 2015, at 7:38 AM, dak@gnu.org wrote: > >> I agree about ...
8 years, 11 months ago (2015-05-07 14:44:19 UTC) #34
paul_paulwmorris.com
> On May 7, 2015, at 10:43 AM, Paul Morris <paul@paulwmorris.com> wrote: > > \relative ...
8 years, 11 months ago (2015-05-07 15:20:12 UTC) #35
dan_faithful.be
On May 7, 2015, at 11:19 , Paul Morris <paul@paulwmorris.com> wrote: > > Here's another ...
8 years, 11 months ago (2015-05-08 01:16:55 UTC) #36
Keith
I tried out a some of these suggestions. On 2015/05/03 16:42:02, Trevor Daniels wrote: > ...
8 years, 11 months ago (2015-05-09 23:58:22 UTC) #37
dak
On 2015/05/09 23:58:22, Keith wrote: > I had seen this selective application as a feature ...
8 years, 11 months ago (2015-05-10 07:25:18 UTC) #38
Keith
On Sun, 10 May 2015 00:25:18 -0700, <dak@gnu.org> wrote: > On 2015/05/09 23:58:22, Keith wrote: ...
8 years, 11 months ago (2015-05-10 21:13:27 UTC) #39
paul_paulwmorris.com
> On May 7, 2015, at 9:16 PM, Dan Eble <dan@faithful.be> wrote: > > \octave ...
8 years, 11 months ago (2015-05-12 13:11:52 UTC) #40
Keith
On 2015/05/12 13:11:52, paul_paulwmorris.com wrote: > > On May 7, 2015, at 9:16 PM, Dan ...
8 years, 11 months ago (2015-05-15 06:06:23 UTC) #41
lemzwerg
> The best choice seems to be \fixed, both for the good fit > of ...
8 years, 11 months ago (2015-05-15 06:12:38 UTC) #42
Keith
On 2015/05/15 06:12:38, lemzwerg wrote: > Given that we are currently producing development > releases, ...
8 years, 11 months ago (2015-05-17 07:36:01 UTC) #43
Trevor Daniels
On 2015/05/17 07:36:01, Keith wrote: > On 2015/05/15 06:12:38, lemzwerg wrote: > > Given that ...
8 years, 11 months ago (2015-05-17 09:56:01 UTC) #44
dak
On 2015/05/17 09:56:01, Trevor Daniels wrote: > On 2015/05/17 07:36:01, Keith wrote: > > On ...
8 years, 11 months ago (2015-05-17 10:44:36 UTC) #45
Trevor Daniels
On 2015/05/17 10:44:36, dak wrote: > > Well, I remain unenthused about the new name. ...
8 years, 11 months ago (2015-05-17 11:58:22 UTC) #46
Keith
On Sun, 17 May 2015 04:58:22 -0700, <tdanielsmusic@googlemail.com> wrote: > The proper name for this ...
8 years, 11 months ago (2015-05-17 18:48:16 UTC) #47
Keith
https://codereview.appspot.com/235010043/diff/140001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/235010043/diff/140001/Documentation/notation/pitches.itely#newcode112 Documentation/notation/pitches.itely:112: The reference pitch after @code{\fixed} is optional. Rather than ...
8 years, 11 months ago (2015-05-17 19:07:06 UTC) #48
dak
"Keith OHara" <k-ohara5a5a@oco.net> writes: > The two functions \fixed and \relative each convert user input ...
8 years, 11 months ago (2015-05-17 21:03:37 UTC) #49
dak
https://codereview.appspot.com/235010043/diff/140001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/235010043/diff/140001/Documentation/notation/pitches.itely#newcode112 Documentation/notation/pitches.itely:112: The reference pitch after @code{\fixed} is optional. On 2015/05/17 ...
8 years, 11 months ago (2015-05-17 21:09:13 UTC) #50
Trevor Daniels
On 2015/05/17 21:09:13, dak wrote: > At any rate, if we were to retain both ...
8 years, 11 months ago (2015-05-17 22:06:10 UTC) #51
Keith
On 2015/05/17 22:06:10, Trevor Daniels wrote: > > I strongly prefer just two input modes, ...
8 years, 11 months ago (2015-05-18 01:12:20 UTC) #52
Keith
On 2015/05/17 22:06:10, Trevor Daniels wrote: > > ... I'd prefer > > the syntax ...
8 years, 11 months ago (2015-05-19 05:47:45 UTC) #53
Keith
I'm proposing to push a \fixed c' {} that always takes a reference pitch, as ...
8 years, 11 months ago (2015-05-21 06:36:59 UTC) #54
paul_paulwmorris.com
8 years, 11 months ago (2015-05-22 15:10:31 UTC) #55
> On May 21, 2015, at 2:36 AM, k-ohara5a5a@oco.net wrote:
> 
> I'm proposing to push a \fixed c' {} that always takes a reference
> pitch, as in the current patch.
> 
> It costs nothing to leave \absolute in place for those who have learned
> it, but it is simplest to document instead the equivalent \fixed c
> {...}.
> 
> That gives us the benefit of less typing and keeps options open for
> behavior of \fixed if we skip the reference pitch.

I’m fine with this proposal.  (I’d be fine with either \octave or \fixed for the
name, FWIW.)

-Paul
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b