Issue 23380044: code review 23380044: [release-branch.go1.2] blog: Make the atom feed title c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23380044: code review 23380044: [release-branch.go1.2] blog: Make the atom feed title c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by adg

Modified:
11 years, 7 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

[release-branch.go1.2] blog: Make the atom feed title configurable. ««« CL 16830043 / 963dd9f808db blog: Make the atom feed title configurable. The blog code is quite generic and with the replacement of template and static files, it can be re-used. But the atom feed title is hard-coded into the code. This patch adds a field to set the atom feed title to the Config structure and uses it in the code where the title was previously hard-coded. A CL sent separately will set this Config field in the main package in the go.blog sub-repository. (See CL 16850043 for that other patch). R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/16830043 Committer: Andrew Gerrand <adg@golang.org> »»»

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	blog/blog.go	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 7 months ago (2013-11-08 02:38:15 UTC) #1

adg

11 years, 7 months ago (2013-11-08 02:46:05 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=650a5ca3bb66&repo=tools ***

[release-branch.go1.2] blog: Make the atom feed title configurable.

««« CL 16830043 / 963dd9f808db
blog: Make the atom feed title configurable.

The blog code is quite generic and with the replacement of template and
static files, it can be re-used. But the atom feed title is hard-coded
into the code. This patch adds a field to set the atom feed title to
the Config structure and uses it in the code where the title was
previously hard-coded.

A CL sent separately will set this Config field in the main package in
the go.blog sub-repository. (See CL 16850043 for that other patch).

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/16830043

Committer: Andrew Gerrand <adg@golang.org>
»»»

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/23380044

Expand All Messages | Collapse All Messages