code review 16830043: blog: Make the atom feed title configurable.

blog: Make the atom feed title configurable.

The blog code is quite generic and with the replacement of template and
static files, it can be re-used. But the atom feed title is hard-coded
into the code. This patch adds a field to set the atom feed title to
the Config structure and uses it in the code where the title was
previously hard-coded.

A CL sent separately will set this Config field in the main package in
the go.blog sub-repository. (See CL 16850043 for that other patch).

[marete, 2013-10-24 21:30:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[marete, 2013-10-24 21:54:42]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2013-10-25 13:51:21]

https://codereview.appspot.com/16830043/diff/40001/blog/blog.go
File blog/blog.go (right):

https://codereview.appspot.com/16830043/diff/40001/blog/blog.go#newcode41
blog/blog.go:41: AtomFeedTitle string // The title of the Atom XML feed
Let's call this FeedTitle

[marete, 2013-10-26 18:50:59]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[marete, 2013-10-26 18:51:55]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2013-10-28 08:13:22]

LGTM

Thanks.

[adg, 2013-10-28 08:17:05]

*** Submitted as
https://code.google.com/p/go/source/detail?r=963dd9f808db&repo=tools ***

blog: Make the atom feed title configurable.

The blog code is quite generic and with the replacement of template and
static files, it can be re-used. But the atom feed title is hard-coded
into the code. This patch adds a field to set the atom feed title to
the Config structure and uses it in the code where the title was
previously hard-coded.

A CL sent separately will set this Config field in the main package in
the go.blog sub-repository. (See CL 16850043 for that other patch).

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/16830043

Committer: Andrew Gerrand <adg@golang.org>