[SHINDIG-1429] Incomplite album and mediaitem support in JS

This patch contains:
* fixed opensocial.Album fields names
* added fields to opensocial.MediaItem
* added functions: newCreateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newFetchMediaItemsRequest

This patch doesn't contain implementation of newUpdateAlbumRequest and newUpdateMediaItemRequest

[henry.saputra, 2010-09-22 15:35:16]

I am having problem seeing the diff for some files. Could you try to do svn
update and regenerate the diff?

On 2010/09/22 07:14:19, ragnor84 wrote:
>

[henry.saputra, 2010-09-23 04:58:16]

The patch missing JsonAlbum file so I added it and create new review:
http://codereview.appspot.com/2246045/

Please let me know if it looks ok.

- Henry

On 2010/09/22 07:14:19, ragnor84 wrote:
>

[ragnor84, 2010-09-23 06:24:04]

This patch was created using Shindig trunk, previously patch using tag Shindig
2.0.0 as code base.

[henry.saputra, 2010-09-23 07:54:58]

Have the jsonrpccontainer.js been tested with the RPC endpoints for Album and
MediaItem?

- Henry

http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
File
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js
(right):

http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:507:
var rpc = { method : "albums.post" };
i think the method should be albums.create per
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/RPC-Protoco...

http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:541:
var rpc = { method : "mediaItems.post" };
I think the method should be mediaItems.Create per
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/RPC-Protoco...

[ragnor84, 2010-09-23 12:13:51]

Added opensocial.newAlbum and modified taming.js

[ragnor84, 2010-09-23 12:21:47]

Code from patch set 3 has been tested and appropriate endpoints was invoked, on
console I usually see: 
org.apache.shindig.protocol.ProtocolException: The method ... is not implemented
because only newFetch[Album|MediaItem]sRequest methods are implemented in my
container.

Best regards,
Jakub


On 2010/09/23 07:54:58, henry.saputra wrote:
> Have the jsonrpccontainer.js been tested with the RPC endpoints for Album and
> MediaItem?
> 
> - Henry
> 
>
http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
> File
> features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js
> (right):
> 
>
http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
>
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:507:
> var rpc = { method : "albums.post" };
> i think the method should be albums.create per
>
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/RPC-Protoco...
> 
>
http://codereview.appspot.com/2265043/diff/10002/features/src/main/javascript...
>
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:541:
> var rpc = { method : "mediaItems.post" };
> I think the method should be mediaItems.Create per
>
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/RPC-Protoco...

[henry.saputra, 2010-09-23 15:23:32]

http://codereview.appspot.com/2265043/diff/27001/features/src/main/javascript...
File
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js
(right):

http://codereview.appspot.com/2265043/diff/27001/features/src/main/javascript...
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:511:
var rpc = { method : "albums.post" };
This should be album.create I believe

http://codereview.appspot.com/2265043/diff/27001/features/src/main/javascript...
features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js:545:
var rpc = { method : "mediaItems.post" };
This should be mediaItems.create

[Paul Lindner, 2010-09-23 18:02:16]

lgtm

[henry.saputra, 2010-09-23 18:37:15]

Oher than comment regarding albums.post to albums.create and mediaItems.post to
mediaItems.create in jsonrpccontainer.js its LGTM too.

[henry.saputra, 2010-09-23 20:23:38]

Patch applied with above changes agreement with Jakub (thanks).

- Henry