Issue 2246045: Patch for SHINDIG-1429: Incomplete Album and MediaItem JavaScript API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2246045: Patch for SHINDIG-1429: Incomplete Album and MediaItem JavaScript API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by henry.saputra

Modified:
13 years ago

Reviewers:
dev, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

The proposed patch come from Jakub Białek. This fix SHINDIG-1429 jira case: -) Fix typos in album.js -) Add fields to mediaitem.js -) Add Json form of the Album and MediaItem. -) Add unit test cases for JSON -) Update pom.xml to include album.js and the unit test files. -) Added newFetchMediaItemsRequest I created this review from http://codereview.appspot.com/2265043/

Patch Set 1 #

Patch Set 2 : guard for opt_params #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+415 lines, -35 lines)			Patch
features/pom.xml	View		2 chunks	+3 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/opensocial-base/feature.xml	View		1 chunk	+2 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/opensocial-base/jsonactivity.js	View		1 chunk	+0 lines, -12 lines	0 comments	Download
features/src/main/javascript/features/opensocial-base/jsonalbum.js	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/opensocial-base/jsonmediaitem.js	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/opensocial-reference/album.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
features/src/main/javascript/features/opensocial-reference/container.js	View		3 chunks	+17 lines, -4 lines	0 comments	Download
features/src/main/javascript/features/opensocial-reference/datarequest.js	View		2 chunks	+52 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/opensocial-reference/mediaitem.js	View		2 chunks	+116 lines, -6 lines	0 comments	Download
features/src/test/javascript/features/alltests.js	View		3 chunks	+5 lines, -0 lines	0 comments	Download
features/src/test/javascript/features/opensocial-base/jsonactivitytest.js	View		1 chunk	+0 lines, -10 lines	0 comments	Download
features/src/test/javascript/features/opensocial-base/jsonalbumtest.js	View		1 chunk	+70 lines, -0 lines	0 comments	Download
features/src/test/javascript/features/opensocial-base/jsonmediaitemtest.js	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

henry.saputra

Proposed fix for SHINDIG-1429 from Jakub. Ported from http://codereview.appspot.com/2265043/ and add some missing files.

13 years, 7 months ago (2010-09-23 05:07:27 UTC) #1

henry.saputra

13 years, 7 months ago (2010-09-23 05:13:33 UTC) #2

Add dev@shindig.apache.org for review since its seems not sent to
dev-remailer@shindig.

Expand All Messages | Collapse All Messages