Issue 20600043: code review 20600043: [release-branch.go1.2] cmd/cgo: use __typeof__, -w inst...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20600043: code review 20600043: [release-branch.go1.2] cmd/cgo: use typeof, -w inst... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by adg

Modified:
11 years, 4 months ago

Reviewers:
dsymonds

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all ««« CL 14920052 / 98840b3349f4 cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all Suggested by iant in earlier CL. R=golang-dev, bradfitz, iant CC=golang-dev https://codereview.appspot.com/14920052 »»»

Patch Set 1 #

Patch Set 2 : diff -r 2d7e5747d2df https://code.google.com/p/go #

Patch Set 3 : diff -r 2d7e5747d2df https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	src/cmd/cgo/doc.go	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
	M	src/cmd/cgo/gcc.go	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2013-11-01 00:14:02 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=485d95c09dee *** [release-branch.go1.2] cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all ««« ...

11 years, 4 months ago (2013-11-01 00:14:27 UTC) #2

LGTM

Expand All Messages | Collapse All Messages