code review 14920052: cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all

cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all

Suggested by iant in earlier CL.

[rsc, 2013-10-22 14:37:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-10-22 15:01:03]

LGTM
 On Oct 22, 2013 7:37 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all
>
> Suggested by iant in earlier CL.
>
> Please review this at
https://codereview.appspot.**com/14920052/<https://codereview.appspot.com/149...
>
> Affected files (+15, -15 lines):
>   M src/cmd/cgo/doc.go
>   M src/cmd/cgo/gcc.go
>
>
> Index: src/cmd/cgo/doc.go
> ==============================**==============================**=======
> --- a/src/cmd/cgo/doc.go
> +++ b/src/cmd/cgo/doc.go
> @@ -270,13 +270,13 @@
>
>         <preamble>
>         #line 1 "not-declared"
> -       void __cgo_f_xxx_1(void) { typeof(foo) *__cgo_undefined__; }
> +       void __cgo_f_xxx_1(void) { __typeof__(foo) *__cgo_undefined__; }
>         #line 1 "not-type"
>         void __cgo_f_xxx_2(void) { foo *__cgo_undefined__; }
>         #line 1 "not-const"
>         void __cgo_f_xxx_3(void) { enum { __cgo_undefined__ = (foo)*1 }; }
>         #line 2 "not-declared"
> -       void __cgo_f_xxx_1(void) { typeof(bar) *__cgo_undefined__; }
> +       void __cgo_f_xxx_1(void) { __typeof__(bar) *__cgo_undefined__; }
>         #line 2 "not-type"
>         void __cgo_f_xxx_2(void) { bar *__cgo_undefined__; }
>         #line 2 "not-const"
> @@ -300,14 +300,14 @@
>  and c6 are constants, it generates:
>
>         <preamble>
> -       typeof(t1) *__cgo__1;
> -       typeof(v2) *__cgo__2;
> -       typeof(v3) *__cgo__3;
> -       typeof(c4) *__cgo__4;
> +       __typeof__(t1) *__cgo__1;
> +       __typeof__(v2) *__cgo__2;
> +       __typeof__(v3) *__cgo__3;
> +       __typeof__(c4) *__cgo__4;
>         enum { __cgo_enum__4 = c4 };
> -       typeof(c5) *__cgo__5;
> +       __typeof__(c5) *__cgo__5;
>         enum { __cgo_enum__5 = c5 };
> -       typeof(c6) *__cgo__6;
> +       __typeof__(c6) *__cgo__6;
>         enum { __cgo_enum__6 = c6 };
>
>         long long __cgo_debug_data[] = {
> Index: src/cmd/cgo/gcc.go
> ==============================**==============================**=======
> --- a/src/cmd/cgo/gcc.go
> +++ b/src/cmd/cgo/gcc.go
> @@ -288,7 +288,7 @@
>         // For each name, we generate these lines, where xxx is the index
> in toSniff plus one.
>         //
>         //      #line xxx "not-declared"
> -       //      void __cgo_f_xxx_1(void) { typeof(name)
> *__cgo_undefined__; }
> +       //      void __cgo_f_xxx_1(void) { __typeof__(name)
> *__cgo_undefined__; }
>         //      #line xxx "not-type"
>         //      void __cgo_f_xxx_2(void) { name *__cgo_undefined__; }
>         //      #line xxx "not-const"
> @@ -309,7 +309,7 @@
>
>         for i, n := range names {
>                 fmt.Fprintf(&b, "#line %d \"not-declared\"\n"+
> -                       "void __cgo_f_%d_1(void) { typeof(%s)
> *__cgo_undefined__; }\n"+
> +                       "void __cgo_f_%d_1(void) { __typeof__(%s)
> *__cgo_undefined__; }\n"+
>                         "#line %d \"not-type\"\n"+
>                         "void __cgo_f_%d_2(void) { %s *__cgo_undefined__;
> }\n"+
>                         "#line %d \"not-const\"\n"+
> @@ -406,14 +406,14 @@
>         // for symbols in the object file, so it is not enough to print the
>         // preamble and hope the symbols we care about will be there.
>         // Instead, emit
> -       //      typeof(names[i]) *__cgo__i;
> +       //      __typeof__(names[i]) *__cgo__i;
>         // for each entry in names and then dereference the type we
>         // learn for __cgo__i.
>         var b bytes.Buffer
>         b.WriteString(f.Preamble)
>         b.WriteString(builtinProlog)
>         for i, n := range names {
> -               fmt.Fprintf(&b, "typeof(%s) *__cgo__%d;\n", n.C, i)
> +               fmt.Fprintf(&b, "__typeof__(%s) *__cgo__%d;\n", n.C, i)
>                 if n.Kind == "const" {
>                         fmt.Fprintf(&b, "enum { __cgo_enum__%d = %s };\n",
> i, n.C)
>                 }
> @@ -742,7 +742,7 @@
>  // the input.
>  func (p *Package) gccCmd() []string {
>         c := append(p.gccBaseCmd(),
> -               "-Wno-all",                          // no warnings
> +               "-w",                                // no warnings
>                 "-Wno-error",                        // warnings are not
> errors
>                 "-o"+gccTmp(),                       // write object to tmp
>                 "-gdwarf-2",                         // generate DWARF v2
> debugging symbols
> @@ -1082,7 +1082,7 @@
>                 sub := c.Type(dt.Type, pos)
>                 t.Align = sub.Align
>                 gt.Elt = sub.Go
> -               t.C.Set("typeof(%s[%d])", sub.C, dt.Count)
> +               t.C.Set("__typeof__(%s[%d])", sub.C, dt.Count)
>
>         case *dwarf.BoolType:
>                 t.Go = c.bool
> @@ -1220,7 +1220,7 @@
>                 case "class", "union":
>                         t.Go = c.Opaque(t.Size)
>                         if t.C.Empty() {
> -                               t.C.Set("typeof(unsigned char[%d])",
> t.Size)
> +                               t.C.Set("__typeof__(unsigned char[%d])",
> t.Size)
>                         }
>                         t.Align = 1 // TODO: should probably base this on
> field alignment.
>                         typedef[name.Name] = t
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[iant, 2013-10-22 15:42:11]

LGTM

[rsc, 2013-10-22 22:33:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=98840b3349f4 ***

cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all

Suggested by iant in earlier CL.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/14920052