Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 20360044: code review 20360044: [release-branch.go1.2] misc/linkcheck: better redirect ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by adg
Modified:
11 years, 4 months ago
Reviewers:
dsymonds
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] misc/linkcheck: better redirect handling, use meaningful exit code ««« CL 14425049 / 093d299d669e misc/linkcheck: better redirect handling, use meaningful exit code Prevent linkcheck from following redirects that lead beyond the outside the root URL. Return a non-zero exit code when there are problems. Some minor refactoring for clarity. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/14425049 »»»

Patch Set 1 #

Patch Set 2 : diff -r 0883b7d7a008 https://code.google.com/p/go #

Patch Set 3 : diff -r 0883b7d7a008 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -32 lines) Patch
M misc/linkcheck/linkcheck.go View 1 4 chunks +58 lines, -32 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2013-11-01 00:19:19 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=288553c874fe *** [release-branch.go1.2] misc/linkcheck: better redirect handling, use meaningful exit code ««« ...
11 years, 4 months ago (2013-11-01 00:19:44 UTC) #2
dsymonds
11 years, 4 months ago (2013-11-01 00:21:55 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b