Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(598)

Issue 14425049: code review 14425049: misc/linkcheck: better redirect handling, use meaningfu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by adg
Modified:
11 years, 4 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

misc/linkcheck: better redirect handling, use meaningful exit code Prevent linkcheck from following redirects that lead beyond the outside the root URL. Return a non-zero exit code when there are problems. Some minor refactoring for clarity.

Patch Set 1 #

Patch Set 2 : diff -r ad51691011d3 https://code.google.com/p/go #

Patch Set 3 : diff -r ad51691011d3 https://code.google.com/p/go #

Patch Set 4 : diff -r 0eb6508d3e88 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -32 lines) Patch
M misc/linkcheck/linkcheck.go View 1 4 chunks +58 lines, -32 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 5 months ago (2013-10-08 05:53:37 UTC) #1
r
R=bradfitz
11 years, 5 months ago (2013-10-15 20:35:01 UTC) #2
bradfitz
LGTM
11 years, 5 months ago (2013-10-15 20:39:49 UTC) #3
adg
11 years, 4 months ago (2013-10-25 14:31:04 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=093d299d669e ***

misc/linkcheck: better redirect handling, use meaningful exit code

Prevent linkcheck from following redirects that lead beyond the outside
the root URL.

Return a non-zero exit code when there are problems.

Some minor refactoring for clarity.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/14425049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b