Issue 14425049: code review 14425049: misc/linkcheck: better redirect handling, use meaningfu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14425049: code review 14425049: misc/linkcheck: better redirect handling, use meaningfu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by adg

Modified:
11 years, 4 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

misc/linkcheck: better redirect handling, use meaningful exit code Prevent linkcheck from following redirects that lead beyond the outside the root URL. Return a non-zero exit code when there are problems. Some minor refactoring for clarity.

Patch Set 1 #

Patch Set 2 : diff -r ad51691011d3 https://code.google.com/p/go #

Patch Set 3 : diff -r ad51691011d3 https://code.google.com/p/go #

Patch Set 4 : diff -r 0eb6508d3e88 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -32 lines)			Patch
	M	misc/linkcheck/linkcheck.go	View	1	4 chunks	+58 lines, -32 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2013-10-08 05:53:37 UTC) #1

adg

11 years, 4 months ago (2013-10-25 14:31:04 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=093d299d669e ***

misc/linkcheck: better redirect handling, use meaningful exit code

Prevent linkcheck from following redirects that lead beyond the outside
the root URL.

Return a non-zero exit code when there are problems.

Some minor refactoring for clarity.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/14425049

Expand All Messages | Collapse All Messages