Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 20050044: code review 20050044: [release-branch.go1.2] cmd/gc: shorten name used for ma... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by adg
Modified:
11 years, 4 months ago
Reviewers:
dsymonds
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] cmd/gc: shorten name used for map bucket type ««« CL 15110044 / 95336afd420c cmd/gc: shorten name used for map bucket type Before: type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } } After: type.map.bucket[string]*"".RangeTable This makes debugging maps a little nicer, and it takes up less space in the binary. R=golang-dev, r CC=golang-dev, khr https://codereview.appspot.com/15110044 »»»

Patch Set 1 #

Patch Set 2 : diff -r d2862cc2bfc5 https://code.google.com/p/go #

Patch Set 3 : diff -r d2862cc2bfc5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/gc/reflect.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2013-10-31 23:59:51 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=0d584450b8e8 *** [release-branch.go1.2] cmd/gc: shorten name used for map bucket type ««« ...
11 years, 4 months ago (2013-11-01 00:00:21 UTC) #2
dsymonds
11 years, 4 months ago (2013-11-01 00:01:25 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b