Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 15110044: code review 15110044: cmd/gc: shorten name used for map bucket type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rsc
Modified:
11 years, 4 months ago
Reviewers:
r
CC:
golang-dev, r, khr
Visibility:
Public.

Description

cmd/gc: shorten name used for map bucket type Before: type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } } After: type.map.bucket[string]*"".RangeTable This makes debugging maps a little nicer, and it takes up less space in the binary.

Patch Set 1 #

Patch Set 2 : diff -r e7ddf900fd19 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e7ddf900fd19 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1e60ffd5933d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/gc/reflect.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com (cc: khr), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2013-10-18 19:28:30 UTC) #1
r
LGTM wow
11 years, 4 months ago (2013-10-18 19:51:20 UTC) #2
rsc
credit to ken for <...>
11 years, 4 months ago (2013-10-18 19:55:54 UTC) #3
rsc
11 years, 4 months ago (2013-10-18 19:56:09 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=95336afd420c ***

cmd/gc: shorten name used for map bucket type

Before:
type.struct { buckets *struct { overflow *struct { overflow *struct { overflow
*struct { overflow *struct { overflow *<...>; keys [8]string; values
[8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string;
values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys
[8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct {
overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys
[8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable
}; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values
[8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } }

After:
type.map.bucket[string]*"".RangeTable

This makes debugging maps a little nicer, and it takes up less space in the
binary.

R=golang-dev, r
CC=golang-dev, khr
https://codereview.appspot.com/15110044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b