Issue 199069: Review: broken getmessage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 199069: Review: broken getmessage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by larrygritz

Modified:
14 years, 10 months ago

Reviewers:
ckulla

CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

In the same way as my last review for string ops, if getmessage had all uniform args but was called from within a varying conditional, it could fill in only the first value of the result.

Patch Set 1 #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
		src/liboslexec/opmessage.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ckulla

LGTM But I still think there are additional corner cases to both setmessage and getmessage ...

14 years, 10 months ago (2010-02-03 01:37:23 UTC) #2

lg_imageworks.com

14 years, 10 months ago (2010-02-03 01:44:23 UTC) #3

Which other cases do you think are broken?

I can try to simplify, but it's a fairly complicated set of moving parts.  I'll
see what I can do.

	-- lg

On Feb 2, 2010, at 5:37 PM, <ckulla@gmail.com> <ckulla@gmail.com> wrote:

> LGTM
> 
> But I still think there are additional corner cases to both setmessage
> and getmessage that might be broken.
> 
> Overall the logic in these ops is quite hard to follow ... is there
> anything we could do to simplify it?
> 
> http://codereview.appspot.com/199069/show
> 

--
Larry Gritz
lg@imageworks.com

Expand All Messages | Collapse All Messages