Code review - Issue 199069: Review: broken getmessagehttps://codereview.appspot.com/2010-02-03T01:44:23+00:00rietveld
Message from unknown
2010-02-03T01:30:25+00:00larrygritzurn:md5:d2cc652bf4d8c4cdaea8aac9e328f0ad
Message from larrygritz@gmail.com
2010-02-03T01:30:25+00:00larrygritzurn:md5:a4cc34231cbbd5ece4389c75b933b165
Message from ckulla@gmail.com
2010-02-03T01:37:23+00:00ckullaurn:md5:ff8e4ecfb0ba5a25097513935f7dc506
LGTM
But I still think there are additional corner cases to both setmessage and getmessage that might be broken.
Overall the logic in these ops is quite hard to follow ... is there anything we could do to simplify it?
Message from lg@imageworks.com
2010-02-03T01:44:23+00:00lg_imageworks.comurn:md5:efd8cc0b7956b75cd3a6136241715ec9
Which other cases do you think are broken?
I can try to simplify, but it's a fairly complicated set of moving parts. I'll see what I can do.
-- lg
On Feb 2, 2010, at 5:37 PM, <ckulla@gmail.com> <ckulla@gmail.com> wrote:
> LGTM
>
> But I still think there are additional corner cases to both setmessage
> and getmessage that might be broken.
>
> Overall the logic in these ops is quite hard to follow ... is there
> anything we could do to simplify it?
>
> http://codereview.appspot.com/199069/show
>
--
Larry Gritz
lg@imageworks.com