Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(893)

Issue 181077: code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dho
Modified:
9 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Fix missing explicit GOBIN in src/pkg/Makefile. Clean up creation of QUOTED_GOBIN Fixes issue 468

Patch Set 1 #

Patch Set 2 : code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile #

Total comments: 1

Patch Set 3 : code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile. Clean u... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M src/Make.conf View 1 chunk +2 lines, -6 lines 0 comments Download
M src/Make.pkg View 2 chunks +2 lines, -8 lines 0 comments Download
M src/pkg/Makefile View 1 2 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5
dho
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
9 years, 7 months ago (2009-12-28 16:33:44 UTC) #1
rsc
http://codereview.appspot.com/181077/diff/1001/4 File src/pkg/Makefile (right): http://codereview.appspot.com/181077/diff/1001/4#newcode13 src/pkg/Makefile:13: nullstring := first two lines can be factored up ...
9 years, 7 months ago (2010-01-05 22:41:28 UTC) #2
dho
PTAL On 2010/01/05 22:41:28, rsc wrote: > http://codereview.appspot.com/181077/diff/1001/4#newcode13 > src/pkg/Makefile:13: nullstring := > first two ...
9 years, 7 months ago (2010-01-05 22:47:11 UTC) #3
rsc
LGTM thanks
9 years, 7 months ago (2010-01-05 22:55:44 UTC) #4
rsc
9 years, 7 months ago (2010-01-06 00:22:45 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=47fc7b4cb1a6 ***

Fix missing explicit GOBIN in src/pkg/Makefile. Clean up creation of
QUOTED_GOBIN

Fixes issue 468

R=rsc
CC=golang-dev
http://codereview.appspot.com/181077

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b