Issue 181077: code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181077: code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by dho

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Fix missing explicit GOBIN in src/pkg/Makefile. Clean up creation of QUOTED_GOBIN Fixes issue 468

Patch Set 2 : code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile #

Total comments: 1

Patch Set 3 : code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile. Clean u... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -18 lines)			Patch
M	src/Make.conf	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/Make.pkg	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/pkg/Makefile	View	1 2	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dho

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

14 years, 4 months ago (2009-12-28 16:33:44 UTC) #1

rsc

http://codereview.appspot.com/181077/diff/1001/4 File src/pkg/Makefile (right): http://codereview.appspot.com/181077/diff/1001/4#newcode13 src/pkg/Makefile:13: nullstring := first two lines can be factored up ...

14 years, 3 months ago (2010-01-05 22:41:28 UTC) #2

dho

PTAL On 2010/01/05 22:41:28, rsc wrote: > http://codereview.appspot.com/181077/diff/1001/4#newcode13 > src/pkg/Makefile:13: nullstring := > first two ...

14 years, 3 months ago (2010-01-05 22:47:11 UTC) #3

rsc

14 years, 3 months ago (2010-01-06 00:22:45 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=47fc7b4cb1a6 ***

Fix missing explicit GOBIN in src/pkg/Makefile. Clean up creation of
QUOTED_GOBIN

Fixes issue 468

R=rsc
CC=golang-dev
http://codereview.appspot.com/181077

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages