Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Unified Diff: src/pkg/Makefile

Issue 181077: code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile (Closed)
Patch Set: code review 181077: Fix missing explicit GOBIN in src/pkg/Makefile. Clean u... Created 14 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/Make.pkg ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pkg/Makefile
===================================================================
--- a/src/pkg/Makefile
+++ b/src/pkg/Makefile
@@ -9,6 +9,14 @@
#
# to rebuild the dependency information in Make.deps.
+nullstring :=
+space := $(nullstring)
+ifndef GOBIN
+QUOTED_HOME=$(subst $(space),\ ,$(HOME))
+GOBIN=$(QUOTED_HOME)/bin
+endif
+QUOTED_GOBIN=$(subst $(space),\ ,$(GOBIN))
+
all: install
DIRS=\
@@ -135,16 +143,16 @@
test.dirs: $(addsuffix .test, $(TEST))
%.clean:
- +cd $* && gomake clean
+ +cd $* && $(QUOTED_GOBIN)/gomake clean
%.install:
- +cd $* && gomake install
+ +cd $* && $(QUOTED_GOBIN)/gomake install
%.nuke:
- +cd $* && gomake nuke
+ +cd $* && $(QUOTED_GOBIN)/gomake nuke
%.test:
- +cd $* && gomake test
+ +cd $* && $(QUOTED_GOBIN)/gomake test
clean: clean.dirs
« no previous file with comments | « src/Make.pkg ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b