Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 1774043: python8954: wininst regression: errors when building on linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by techtonik
Modified:
11 years, 8 months ago
Reviewers:
Ezio Melotti
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/Lib/distutils/command/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : reupload correct version #

Total comments: 4

Patch Set 3 : Tidy up comments per Ezio notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M bdist_wininst.py View 1 2 6 chunks +32 lines, -9 lines 0 comments Download

Messages

Total messages: 2
Ezio Melotti
http://codereview.appspot.com/1774043/diff/2001/3001 File bdist_wininst.py (right): http://codereview.appspot.com/1774043/diff/2001/3001#newcode12 bdist_wininst.py:12: the same compiler python itself is compiled with, i.e. ...
12 years, 2 months ago (2010-07-12 11:44:17 UTC) #1
techtonik
11 years, 8 months ago (2011-01-09 16:58:59 UTC) #2
Done.

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py
File bdist_wininst.py (right):

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode12
bdist_wininst.py:12: the same compiler python itself is compiled with, i.e.
Visual Studio.
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Python should be capitalized, here, in the list and a few lines later. Same
for
> Windows.

Done.

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode78
bdist_wininst.py:78: # win-amd64 (64bit Windows on AMD64 (aka x86_64, Intel64,
EM64T, etc)
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Odd number of parentheses.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b