Code review - Issue 1774043: python8954: wininst regression: errors when building on linuxhttps://codereview.appspot.com/2011-01-09T16:58:59+00:00rietveld
Message from unknown
2010-07-12T08:44:14+00:00techtonikurn:md5:c3cb103ac845b6a95ef43f8eea863f38
Message from unknown
2010-07-12T11:36:29+00:00techtonikurn:md5:88e1db0263b8783ebcc2adef7775cfe6
Message from ezio.melotti@gmail.com
2010-07-12T11:44:17+00:00Ezio Melottiurn:md5:d8fd1ea4a749b54eff2bf941c3660379
http://codereview.appspot.com/1774043/diff/2001/3001
File bdist_wininst.py (right):
http://codereview.appspot.com/1774043/diff/2001/3001#newcode12
bdist_wininst.py:12: the same compiler python itself is compiled with, i.e. Visual Studio.
Python should be capitalized, here, in the list and a few lines later. Same for Windows.
http://codereview.appspot.com/1774043/diff/2001/3001#newcode78
bdist_wininst.py:78: # win-amd64 (64bit Windows on AMD64 (aka x86_64, Intel64, EM64T, etc)
Odd number of parentheses.
Message from unknown
2011-01-09T16:52:47+00:00techtonikurn:md5:df3f911eb11b40ffae7e88a160c30831
Message from techtonik@gmail.com
2011-01-09T16:58:59+00:00techtonikurn:md5:0b328fc36aac643174a05614b32f1c23
Done.
http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py
File bdist_wininst.py (right):
http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode12
bdist_wininst.py:12: the same compiler python itself is compiled with, i.e. Visual Studio.
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Python should be capitalized, here, in the list and a few lines later. Same for
> Windows.
Done.
http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode78
bdist_wininst.py:78: # win-amd64 (64bit Windows on AMD64 (aka x86_64, Intel64, EM64T, etc)
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Odd number of parentheses.
Done.