Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 1711048: code review 1711048: freetype/raster: make cap and join functions instead of... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by nigeltao
Modified:
5 days, 21 hours ago
Reviewers:
adg
CC:
adg, golang-dev, rog
Visibility:
Public.

Description

freetype/raster: make cap and join functions instead of enums.

Patch Set 1 #

Patch Set 2 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Total comments: 2

Patch Set 3 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Patch Set 4 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -69 lines) Patch
M freetype/raster/geom.go View 1 2 3 7 chunks +85 lines, -67 lines 0 comments Download
M freetype/raster/raster.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello rsc (cc: golang-dev@googlegroups.com, rog), I'd like you to review this change.
8 years, 5 months ago (2010-07-01 01:03:52 UTC) #1
nigeltao
Russ is away. Andrew -- can you look at this?
8 years, 5 months ago (2010-07-06 01:26:20 UTC) #2
adg
LGTM A couple of nits. http://codereview.appspot.com/1711048/diff/2001/3001 File freetype/raster/geom.go (right): http://codereview.appspot.com/1711048/diff/2001/3001#newcode276 freetype/raster/geom.go:276: Cap(p Adder, halfWidth Fix32, ...
8 years, 5 months ago (2010-07-06 01:57:32 UTC) #3
nigeltao
*** Submitted as http://code.google.com/p/freetype-go/source/detail?r=ef6d018e1c6f *** freetype/raster: make cap and join functions instead of enums. R=adg ...
8 years, 5 months ago (2010-07-07 11:55:18 UTC) #4
nigeltao_gnome
8 years, 5 months ago (2010-07-07 12:05:17 UTC) #5
On 6 July 2010 11:57,  <adg@golang.org> wrote:
> A couple of nits.
>
> http://codereview.appspot.com/1711048/diff/2001/3001
> File freetype/raster/geom.go (right):
>
> http://codereview.appspot.com/1711048/diff/2001/3001#newcode276
> freetype/raster/geom.go:276: Cap(p Adder, halfWidth Fix32, pivot, n1
> Point)
> Cap(Adder, Fix32, Point, Point)
>
> ?

I kept the argument names, since they're referred to in the doc
comment to the interface method.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b