Issue 1711048: code review 1711048: freetype/raster: make cap and join functions instead of...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1711048: code review 1711048: freetype/raster: make cap and join functions instead of... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by nigeltao

Modified:
5 years, 11 months ago

Reviewers:
adg

CC:
adg, golang-dev, rog

Visibility:
Public.

Description

freetype/raster: make cap and join functions instead of enums.

Patch Set 2 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Total comments: 2

Patch Set 3 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Patch Set 4 : code review 1711048: freetype/raster: make cap and join functions instead of... #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -69 lines)			Patch
	M	freetype/raster/geom.go	View	1 2 3	7 chunks	+85 lines, -67 lines	0 comments	Download
	M	freetype/raster/raster.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc (cc: golang-dev@googlegroups.com, rog), I'd like you to review this change.

14 years, 5 months ago (2010-07-01 01:03:52 UTC) #1

adg

LGTM A couple of nits. http://codereview.appspot.com/1711048/diff/2001/3001 File freetype/raster/geom.go (right): http://codereview.appspot.com/1711048/diff/2001/3001#newcode276 freetype/raster/geom.go:276: Cap(p Adder, halfWidth Fix32, ...

14 years, 4 months ago (2010-07-06 01:57:32 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/freetype-go/source/detail?r=ef6d018e1c6f *** freetype/raster: make cap and join functions instead of enums. R=adg ...

14 years, 4 months ago (2010-07-07 11:55:18 UTC) #4

nigeltao_gnome

14 years, 4 months ago (2010-07-07 12:05:17 UTC) #5

On 6 July 2010 11:57,  <adg@golang.org> wrote:
> A couple of nits.
>
> http://codereview.appspot.com/1711048/diff/2001/3001
> File freetype/raster/geom.go (right):
>
> http://codereview.appspot.com/1711048/diff/2001/3001#newcode276
> freetype/raster/geom.go:276: Cap(p Adder, halfWidth Fix32, pivot, n1
> Point)
> Cap(Adder, Fix32, Point, Point)
>
> ?

I kept the argument names, since they're referred to in the doc
comment to the interface method.

Expand All Messages | Collapse All Messages